Add doc URL to the addon list table #14123

Rabattkarte · 2022-05-09T18:25:18Z

I'd like to address two open thoughts:

I was unable to find docs for all addons. This might result in a new backlog item to create those docs?
Do we have some sort of short URL to replace the bulky https://minikube.sigs.k8s.io/docs/ in the output below?

I'm very open to any feedback. Cheers!

Before:

$ minikube addons list
|-----------------------------|--------------------------------|
|         ADDON NAME          |           MAINTAINER           |
|-----------------------------|--------------------------------|
| ambassador                  | third-party (ambassador)       |
| auto-pause                  | google                         |
| csi-hostpath-driver         | kubernetes                     |
| dashboard                   | kubernetes                     |
| default-storageclass        | kubernetes                     |
| efk                         | third-party (elastic)          |
| freshpod                    | google                         |
| gcp-auth                    | google                         |
| gvisor                      | google                         |
| helm-tiller                 | third-party (helm)             |
| ingress                     | unknown (third-party)          |
| ingress-dns                 | google                         |
| istio                       | third-party (istio)            |
| istio-provisioner           | third-party (istio)            |
| kong                        | third-party (Kong HQ)          |
| kubevirt                    | third-party (kubevirt)         |
| logviewer                   | unknown (third-party)          |
| metallb                     | third-party (metallb)          |
| metrics-server              | kubernetes                     |
| nvidia-driver-installer     | google                         |
| nvidia-gpu-device-plugin    | third-party (nvidia)           |
| olm                         | third-party (operator          |
|                             | framework)                     |
| pod-security-policy         | unknown (third-party)          |
| portainer                   | portainer.io                   |
| registry                    | google                         |
| registry-aliases            | unknown (third-party)          |
| registry-creds              | third-party (upmc enterprises) |
| storage-provisioner         | google                         |
| storage-provisioner-gluster | unknown (third-party)          |
| volumesnapshots             | kubernetes                     |
|-----------------------------|--------------------------------|

After:

|-----------------------------|--------------------------------|-----------------------------------------------------------------|
|         ADDON NAME          |           MAINTAINER           |                              DOCS                               |
|-----------------------------|--------------------------------|-----------------------------------------------------------------|
| ambassador                  | third-party (ambassador)       | n/a                                                             |
| auto-pause                  | google                         | n/a                                                             |
| csi-hostpath-driver         | kubernetes                     | n/a                                                             |
| dashboard                   | kubernetes                     | https://minikube.sigs.k8s.io/docs/handbook/dashboard/           |
| default-storageclass        | kubernetes                     | n/a                                                             |
| efk                         | third-party (elastic)          | n/a                                                             |
| freshpod                    | google                         | n/a                                                             |
| gcp-auth                    | google                         | https://minikube.sigs.k8s.io/docs/handbook/addons/gcp-auth/     |
| gvisor                      | google                         | n/a                                                             |
| helm-tiller                 | third-party (helm)             | n/a                                                             |
| ingress                     | unknown (third-party)          | n/a                                                             |
| ingress-dns                 | google                         | https://minikube.sigs.k8s.io/docs/handbook/addons/ingress-dns/  |
| istio                       | third-party (istio)            | n/a                                                             |
| istio-provisioner           | third-party (istio)            | n/a                                                             |
| kong                        | third-party (Kong HQ)          | https://minikube.sigs.k8s.io/docs/handbook/addons/kong-ingress/ |
| kubevirt                    | third-party (kubevirt)         | n/a                                                             |
| logviewer                   | unknown (third-party)          | n/a                                                             |
| metallb                     | third-party (metallb)          | n/a                                                             |
| metrics-server              | kubernetes                     | n/a                                                             |
| nvidia-driver-installer     | google                         | n/a                                                             |
| nvidia-gpu-device-plugin    | third-party (nvidia)           | n/a                                                             |
| olm                         | third-party (operator          | n/a                                                             |
|                             | framework)                     |                                                                 |
| pod-security-policy         | unknown (third-party)          | n/a                                                             |
| portainer                   | portainer.io                   | n/a                                                             |
| registry                    | google                         | n/a                                                             |
| registry-aliases            | unknown (third-party)          | n/a                                                             |
| registry-creds              | third-party (upmc enterprises) | n/a                                                             |
| storage-provisioner         | google                         | n/a                                                             |
| storage-provisioner-gluster | unknown (third-party)          | n/a                                                             |
| volumesnapshots             | kubernetes                     | n/a                                                             |
|-----------------------------|--------------------------------|-----------------------------------------------------------------|

linux-foundation-easycla · 2022-05-09T18:25:20Z

The committers listed above are authorized under a signed CLA.

✅ login: Rabattkarte / name: Nils Fahldieck (d2fab5b)

k8s-ci-robot · 2022-05-09T18:25:25Z

Welcome @Rabattkarte!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-05-09T18:25:26Z

Hi @Rabattkarte. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-05-09T18:30:04Z

Can one of the admins verify this patch?

Rabattkarte · 2022-05-09T18:53:33Z

I had to update my Git user/email for this patch. Sorry for the force push. This is ready to review now.

Rabattkarte · 2022-05-10T12:16:51Z

I just had some thoughts and will flesh this out a little more, so I migrated this PR to draft status.

Rabattkarte · 2022-05-17T13:56:43Z

This PR is ready to review and possibly merge. I dug out some more docs and added them. I'm happy to any feedback.

The list output now looks like this:

$ ./out/minikube-darwin-amd64 addons list
|-----------------------------|----------|--------------|--------------------------------|-----------------------------------------------------------------------------------|
|         ADDON NAME          | PROFILE  |    STATUS    |           MAINTAINER           |                                       DOCS                                        |
|-----------------------------|----------|--------------|--------------------------------|-----------------------------------------------------------------------------------|
| ambassador                  | minikube | disabled     | 3rd party (ambassador)         | https://minikube.sigs.k8s.io/docs/tutorials/ambassador_ingress_controller/        |
| auto-pause                  | minikube | disabled     | google                         | n/a                                                                               |
| csi-hostpath-driver         | minikube | disabled     | kubernetes                     | https://minikube.sigs.k8s.io/docs/tutorials/volume_snapshots_and_csi/             |
| dashboard                   | minikube | disabled     | kubernetes                     | https://minikube.sigs.k8s.io/docs/handbook/dashboard/                             |
| default-storageclass        | minikube | enabled ✅   | kubernetes                     | https://minikube.sigs.k8s.io/docs/handbook/persistent_volumes/                    |
| efk                         | minikube | disabled     | 3rd party (elastic)            | n/a                                                                               |
| freshpod                    | minikube | disabled     | google                         | https://github.com/GoogleCloudPlatform/freshpod                                   |
| gcp-auth                    | minikube | disabled     | google                         | https://minikube.sigs.k8s.io/docs/handbook/addons/gcp-auth/                       |
| gvisor                      | minikube | disabled     | google                         | https://github.com/kubernetes/minikube/blob/master/deploy/addons/gvisor/README.md |
| helm-tiller                 | minikube | disabled     | 3rd party (helm)               | https://v2.helm.sh/docs/using_helm/                                               |
| ingress                     | minikube | disabled     | 3rd party (unknown)            | https://kubernetes.io/docs/tasks/access-application-cluster/ingress-minikube/     |
| ingress-dns                 | minikube | disabled     | google                         | https://minikube.sigs.k8s.io/docs/handbook/addons/ingress-dns/                    |
| istio                       | minikube | disabled     | 3rd party (istio)              | https://istio.io/latest/docs/setup/platform-setup/minikube/                       |
| istio-provisioner           | minikube | disabled     | 3rd party (istio)              | https://istio.io/latest/docs/setup/platform-setup/minikube/                       |
| kong                        | minikube | disabled     | 3rd party (Kong HQ)            | https://minikube.sigs.k8s.io/docs/handbook/addons/kong-ingress/                   |
| kubevirt                    | minikube | disabled     | 3rd party (kubevirt)           | https://minikube.sigs.k8s.io/docs/tutorials/kubevirt/                             |
| logviewer                   | minikube | disabled     | 3rd party (unknown)            | n/a                                                                               |
| metallb                     | minikube | disabled     | 3rd party (metallb)            | n/a                                                                               |
| metrics-server              | minikube | disabled     | kubernetes                     | n/a                                                                               |
| nvidia-driver-installer     | minikube | disabled     | google                         | https://minikube.sigs.k8s.io/docs/tutorials/nvidia_gpu/                           |
| nvidia-gpu-device-plugin    | minikube | disabled     | 3rd party (nvidia)             | https://minikube.sigs.k8s.io/docs/tutorials/nvidia_gpu/                           |
| olm                         | minikube | disabled     | 3rd party (operator framework) | n/a                                                                               |
| pod-security-policy         | minikube | disabled     | 3rd party (unknown)            | n/a                                                                               |
| portainer                   | minikube | disabled     | portainer.io                   | n/a                                                                               |
| registry                    | minikube | disabled     | google                         | n/a                                                                               |
| registry-aliases            | minikube | disabled     | 3rd party (unknown)            | n/a                                                                               |
| registry-creds              | minikube | disabled     | 3rd party (upmc enterprises)   | https://minikube.sigs.k8s.io/docs/handbook/registry/                              |
| storage-provisioner         | minikube | enabled ✅   | google                         | n/a                                                                               |
| storage-provisioner-gluster | minikube | disabled     | 3rd party (unknown)            | n/a                                                                               |
| volumesnapshots             | minikube | disabled     | kubernetes                     | n/a                                                                               |
|-----------------------------|----------|--------------|--------------------------------|-----------------------------------------------------------------------------------|

/cc: @prezha @spowelljr @medyagh

sharifelgamal · 2022-05-25T18:46:46Z

I like the idea of including the docs in the addons list output, but this feels a little unwieldy to be the default output. Could we maybe hide the column behind a flag (--full or --docs maybe)? It's definitely useful information.

Rabattkarte · 2022-05-27T15:48:00Z

@sharifelgamal good idea! I have implemented that option.

--help output:

$ ./out/minikube-darwin-amd64 addons list --help
Lists all available minikube addons as well as their current statuses (enabled/disabled)

Options:
    -d, --docs=false:
        If true, print web links to addons' documentation.

    -o, --output='list':
        minikube addons list --output OUTPUT. json, list

Usage:
  minikube addons list [flags] [options]

Use "minikube options" for a list of global command-line options (applies to all commands).

Without option (default false):

$ ./out/minikube-darwin-amd64 addons list
|-----------------------------|--------------------------------|
|         ADDON NAME          |           MAINTAINER           |
|-----------------------------|--------------------------------|
| ambassador                  | 3rd party (ambassador)         |
| auto-pause                  | google                         |
| csi-hostpath-driver         | kubernetes                     |
| dashboard                   | kubernetes                     |

With option:

$ ./out/minikube-darwin-amd64 addons list --docs
|-----------------------------|--------------------------------|-----------------------------------------------------------------------------------|
|         ADDON NAME          |           MAINTAINER           |                                       DOCS                                        |
|-----------------------------|--------------------------------|-----------------------------------------------------------------------------------|
| ambassador                  | 3rd party (ambassador)         | https://minikube.sigs.k8s.io/docs/tutorials/ambassador_ingress_controller/        |
| auto-pause                  | google                         | n/a                                                                               |
| csi-hostpath-driver         | kubernetes                     | https://minikube.sigs.k8s.io/docs/tutorials/volume_snapshots_and_csi/             |
| dashboard                   | kubernetes                     | https://minikube.sigs.k8s.io/docs/handbook/dashboard/                             |

spowelljr

Not directly related to your PR, but since you're updating third-party to 3rd party we might as well fix up the capitalization while you're at it if you don't mind, thanks!

pkg/minikube/assets/addons.go

cmd/minikube/cmd/config/addons_list.go

cmd/minikube/cmd/config/addons_list_test.go

cmd/minikube/cmd/config/addons_list.go

minikube-pr-bot · 2022-05-31T18:41:48Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14123) |
+----------------+----------+---------------------+
| minikube start | 52.1s    | 51.6s               |
| enable ingress | 26.8s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 53.4s 54.7s 50.0s 51.1s 51.4s
Times for minikube (PR 14123) start: 53.4s 51.2s 50.9s 52.0s 50.4s

Times for minikube ingress: 25.5s 25.6s 28.5s 25.6s 29.0s
Times for minikube (PR 14123) ingress: 25.6s 30.1s 28.5s 28.6s 26.1s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14123) |
+-------------------+----------+---------------------+
| minikube start    | 24.5s    | 23.7s               |
| ⚠️  enable ingress | 22.6s    | 46.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 14123) start: 23.4s 23.5s 23.9s 23.7s 23.9s
Times for minikube start: 25.3s 24.2s 24.6s 24.2s 24.3s

Times for minikube ingress: 23.9s 22.4s 22.4s 21.9s 22.4s
Times for minikube (PR 14123) ingress: 21.4s 82.5s 84.4s 21.4s 21.9s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14123) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 29.6s    | 36.3s ⚠️             |
| enable ingress    | 21.4s    | 20.5s               |
+-------------------+----------+---------------------+

Times for minikube (PR 14123) start: 39.0s 31.9s 28.5s 38.9s 43.3s
Times for minikube start: 30.8s 28.9s 31.6s 28.6s 28.1s

Times for minikube ingress: 21.9s 22.4s 18.9s 22.4s 21.4s
Times for minikube (PR 14123) ingress: 22.4s 18.9s 22.4s 21.4s 17.4s

minikube-pr-bot · 2022-05-31T18:55:54Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14123) |
+----------------+----------+---------------------+
| minikube start | 51.5s    | 50.8s               |
| enable ingress | 29.3s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube start: 52.9s 51.5s 50.6s 51.5s 51.1s
Times for minikube (PR 14123) start: 50.8s 52.2s 50.6s 50.1s 50.1s

Times for minikube ingress: 28.7s 30.1s 29.2s 29.1s 29.6s
Times for minikube (PR 14123) ingress: 28.7s 29.1s 29.6s 29.1s 27.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14123) |
+----------------+----------+---------------------+
| minikube start | 26.1s    | 25.1s               |
| enable ingress | 22.6s    | 23.2s               |
+----------------+----------+---------------------+

Times for minikube start: 28.0s 26.7s 25.1s 25.3s 25.2s
Times for minikube (PR 14123) start: 24.5s 24.9s 24.9s 25.6s 25.6s

Times for minikube ingress: 21.9s 22.5s 22.5s 22.9s 23.0s
Times for minikube (PR 14123) ingress: 21.0s 23.5s 22.0s 25.5s 23.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14123) |
+----------------+----------+---------------------+
| minikube start | 36.0s    | 32.0s               |
| enable ingress | 24.5s    | 25.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.9s 28.9s 22.4s 22.0s 20.0s
Times for minikube (PR 14123) ingress: 32.0s 23.0s 22.0s 22.5s 29.0s

Times for minikube start: 33.8s 43.7s 29.2s 40.7s 32.5s
Times for minikube (PR 14123) start: 29.8s 28.4s 29.3s 40.7s 31.9s

minikube-pr-bot · 2022-05-31T20:14:49Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	0.00 (chart)
Docker_macOS	TestPause/serial/VerifyStatus (gopogh)	0.00 (chart)
Docker_macOS	TestPreload (gopogh)	0.00 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	0.00 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	0.00 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	0.00 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh)	0.00 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	0.00 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	0.00 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/Setup (gopogh)	0.00 (chart)
none_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	0.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	1.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	1.01 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	9.09 (chart)
Docker_Windows	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh)	11.11 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	12.12 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/Stop (gopogh)	15.18 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	16.16 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	18.56 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	39.00 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/no-preload/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/Pause (gopogh)	44.90 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2022-05-31T20:47:59Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestDownloadOnly/v1.23.6/preload-exists (gopogh)	n/a
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	0.00 (chart)
Docker_macOS	TestPause/serial/VerifyStatus (gopogh)	0.00 (chart)
Docker_macOS	TestPreload (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/serial/LogsFileCmd (gopogh)	0.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	1.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	1.01 (chart)
Docker_macOS	TestDownloadOnlyKic (gopogh)	1.92 (chart)
KVM_Linux	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	2.61 (chart)
Docker_Windows	TestPause/serial/PauseAgain (gopogh)	5.56 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	9.09 (chart)
Docker_Windows	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh)	11.11 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	12.12 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	16.16 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	18.56 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	26.00 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/no-preload/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	42.86 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	44.19 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/Pause (gopogh)	44.90 (chart)
Docker_Windows	TestRunningBinaryUpgrade (gopogh)	53.33 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	56.19 (chart)
Docker_Windows	TestNoKubernetes/serial/Start (gopogh)	58.25 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Rabattkarte · 2022-06-03T07:29:44Z

@spowelljr I rebased as the bot wished. Can I also auto-squash to get rid of those fixup commits or is this frowned upon?

minikube-pr-bot · 2022-06-03T08:16:29Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14123) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 51.2s               |
| enable ingress | 27.9s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 52.6s 50.5s 51.3s 50.5s 49.7s
Times for minikube (PR 14123) start: 51.6s 50.9s 50.5s 51.9s 51.3s

Times for minikube (PR 14123) ingress: 25.6s 25.5s 24.5s 29.5s 28.1s
Times for minikube ingress: 25.5s 26.5s 29.5s 29.1s 29.1s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14123) |
+-------------------+----------+---------------------+
| minikube start    | 24.9s    | 24.4s               |
| ⚠️  enable ingress | 22.9s    | 35.4s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 27.8s 23.9s 24.0s 24.5s 24.4s
Times for minikube (PR 14123) start: 24.2s 24.7s 24.6s 24.4s 24.1s

Times for minikube (PR 14123) ingress: 26.4s 22.4s 22.9s 82.9s 22.4s
Times for minikube ingress: 22.9s 23.9s 22.0s 23.9s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14123) |
+----------------+----------+---------------------+
| minikube start | 35.6s    | 34.1s               |
| enable ingress | 19.9s    | 24.9s               |
+----------------+----------+---------------------+

Times for minikube start: 29.8s 29.0s 43.8s 31.6s 43.6s
Times for minikube (PR 14123) start: 39.8s 32.2s 39.7s 30.8s 28.1s

Times for minikube ingress: 22.4s 21.9s 18.4s 18.9s 17.9s
Times for minikube (PR 14123) ingress: 22.0s 18.9s 32.4s 28.9s 22.4s

minikube-pr-bot · 2022-06-03T09:50:20Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestMinikubeProfile (gopogh)	n/a
Docker_macOS	TestCertOptions (gopogh)	0.00 (chart)
Docker_macOS	TestDockerFlags (gopogh)	0.00 (chart)
Docker_macOS	TestForceSystemdEnv (gopogh)	0.00 (chart)
Docker_macOS	TestForceSystemdFlag (gopogh)	0.00 (chart)
Docker_Linux	TestNoKubernetes/serial/StartNoArgs (gopogh)	0.63 (chart)
Docker_macOS	TestCertExpiration (gopogh)	1.04 (chart)
Docker_macOS	TestPause/serial/Start (gopogh)	1.04 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	1.05 (chart)
Docker_macOS	TestNoKubernetes/serial/StartWithK8s (gopogh)	2.08 (chart)
Docker_macOS	TestNoKubernetes/serial/Stop (gopogh)	2.13 (chart)
Docker_macOS	TestNetworkPlugins/group/auto/Start (gopogh)	2.17 (chart)
Docker_macOS	TestNetworkPlugins/group/false/Start (gopogh)	2.17 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/Stop (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh)	2.27 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/EnableAddonAfterStop (gopogh)	2.27 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr · 2022-06-03T16:58:39Z

@spowelljr I rebased as the bot wished. Can I also auto-squash to get rid of those fixup commits or is this frowned upon?

Feel free to squash if you'd like

Co-authored-by: Steven Powell <[email protected]>

Rabattkarte · 2022-06-04T15:01:49Z

I rebased & cleaned the commits up. IMO this PR is ready to be merged, @spowelljr?

minikube-pr-bot · 2022-06-04T15:49:20Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14123) |
+----------------+----------+---------------------+
| minikube start | 51.5s    | 51.3s               |
| enable ingress | 27.7s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube start: 53.4s 50.7s 50.5s 51.3s 51.7s
Times for minikube (PR 14123) start: 51.0s 51.3s 51.0s 50.9s 52.1s

Times for minikube ingress: 29.0s 29.5s 29.1s 26.1s 24.6s
Times for minikube (PR 14123) ingress: 26.0s 30.1s 26.5s 28.0s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14123) |
+----------------+----------+---------------------+
| minikube start | 25.0s    | 23.9s               |
| enable ingress | 29.9s    | 26.1s               |
+----------------+----------+---------------------+

Times for minikube start: 27.2s 23.6s 25.1s 24.7s 24.3s
Times for minikube (PR 14123) start: 24.4s 23.3s 24.0s 24.0s 24.0s

Times for minikube (PR 14123) ingress: 38.9s 22.9s 22.9s 23.4s 22.4s
Times for minikube ingress: 30.4s 22.9s 25.9s 48.9s 21.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14123) |
+----------------+----------+---------------------+
| minikube start | 34.8s    | 34.6s               |
| enable ingress | 20.9s    | 21.1s               |
+----------------+----------+---------------------+

Times for minikube start: 30.4s 28.6s 27.9s 43.5s 43.5s
Times for minikube (PR 14123) start: 29.1s 31.6s 40.3s 43.9s 28.3s

Times for minikube ingress: 22.4s 23.5s 22.4s 17.9s 18.4s
Times for minikube (PR 14123) ingress: 22.4s 18.9s 22.4s 18.4s 23.4s

minikube-pr-bot · 2022-06-04T17:18:39Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestMinikubeProfile (gopogh)	n/a
Docker_Linux	TestNetworkPlugins/group/cilium/Start (gopogh)	0.62 (chart)
Docker_Linux	TestAddons/parallel/Registry (gopogh)	1.88 (chart)
Docker_Linux	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	1.88 (chart)
Docker_Linux	TestMultiNode/serial/DeployApp2Nodes (gopogh)	1.88 (chart)
Docker_Linux	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	1.88 (chart)
Docker_Linux	TestFunctional/parallel/DashboardCmd (gopogh)	2.50 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	7.83 (chart)
Docker_Linux	TestNetworkPlugins/group/auto/DNS (gopogh)	8.28 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/auto/Start (gopogh)	9.52 (chart)
Docker_Linux	TestNetworkPlugins/group/kindnet/Start (gopogh)	32.50 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/DNS (gopogh)	48.15 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	50.00 (chart)
Docker_Windows	TestAddons/Setup (gopogh)	51.85 (chart)
Docker_Windows	TestErrorSpam/setup (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/CertSync (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/CpCmd (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/DockerEnv/powershell (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/FileSync (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageListJson (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageListShort (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageListTable (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	51.85 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	51.85 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2022-06-06T21:53:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rabattkarte, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 9, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2022

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2022

k8s-ci-robot requested review from prezha and spowelljr May 9, 2022 18:25

Rabattkarte force-pushed the 7731-add-doc-url branch from fc8c579 to d2fab5b Compare May 9, 2022 18:49

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 9, 2022

Rabattkarte marked this pull request as draft May 10, 2022 12:16

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2022

Rabattkarte force-pushed the 7731-add-doc-url branch from d2fab5b to a56872c Compare May 17, 2022 13:50

Rabattkarte marked this pull request as ready for review May 17, 2022 13:56

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2022

k8s-ci-robot requested review from klaases and prasadkatti May 17, 2022 13:57

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2022

spowelljr requested changes May 27, 2022

View reviewed changes

spowelljr reviewed May 27, 2022

View reviewed changes

cmd/minikube/cmd/config/addons_list.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/config/addons_list_test.go Outdated Show resolved Hide resolved

Rabattkarte requested a review from spowelljr May 30, 2022 08:37

spowelljr requested changes May 31, 2022

View reviewed changes

cmd/minikube/cmd/config/addons_list.go Outdated Show resolved Hide resolved

Rabattkarte requested a review from spowelljr May 31, 2022 17:41

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2022

Rabattkarte force-pushed the 7731-add-doc-url branch from 69d0258 to 0e209ad Compare June 3, 2022 07:26

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2022

Rabattkarte and others added 9 commits June 4, 2022 16:56

Add doc URL to the addon list table

216b630

Use "3rd party (maintainer)" across all strings

967b439

Add additional links to addons' docs

b6239e6

Print doc only with enabled option

8be1b15

Capitalize addon maintainers

e3e7c72

Co-authored-by: Steven Powell <[email protected]>

Add test for disabled/enabled docs

fa3ec14

Conditionally append docs to tData

ce08c0b

Update docs usage output

dfa3716

generate-docs

c44d2e2

Rabattkarte force-pushed the 7731-add-doc-url branch from 0e209ad to c44d2e2 Compare June 4, 2022 14:59

illume mentioned this pull request Jun 6, 2022

Addon: add headlamp kinvolk/minikube#7

Closed

spowelljr approved these changes Jun 6, 2022

View reviewed changes

spowelljr merged commit 2015ae0 into kubernetes:master Jun 6, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add doc URL to the addon list table #14123

Add doc URL to the addon list table #14123

Rabattkarte commented May 9, 2022

linux-foundation-easycla bot commented May 9, 2022 •

edited

Loading

k8s-ci-robot commented May 9, 2022

k8s-ci-robot commented May 9, 2022

minikube-bot commented May 9, 2022

Rabattkarte commented May 9, 2022

Rabattkarte commented May 10, 2022

Rabattkarte commented May 17, 2022

sharifelgamal commented May 25, 2022

Rabattkarte commented May 27, 2022

spowelljr left a comment

minikube-pr-bot commented May 31, 2022

minikube-pr-bot commented May 31, 2022

minikube-pr-bot commented May 31, 2022

minikube-pr-bot commented May 31, 2022

Rabattkarte commented Jun 3, 2022

minikube-pr-bot commented Jun 3, 2022

minikube-pr-bot commented Jun 3, 2022

spowelljr commented Jun 3, 2022

Rabattkarte commented Jun 4, 2022

minikube-pr-bot commented Jun 4, 2022

minikube-pr-bot commented Jun 4, 2022

k8s-ci-robot commented Jun 6, 2022

Add doc URL to the addon list table #14123

Add doc URL to the addon list table #14123

Conversation

Rabattkarte commented May 9, 2022

Before:

After:

linux-foundation-easycla bot commented May 9, 2022 • edited Loading

k8s-ci-robot commented May 9, 2022

k8s-ci-robot commented May 9, 2022

minikube-bot commented May 9, 2022

Rabattkarte commented May 9, 2022

Rabattkarte commented May 10, 2022

Rabattkarte commented May 17, 2022

sharifelgamal commented May 25, 2022

Rabattkarte commented May 27, 2022

spowelljr left a comment

Choose a reason for hiding this comment

minikube-pr-bot commented May 31, 2022

minikube-pr-bot commented May 31, 2022

minikube-pr-bot commented May 31, 2022

minikube-pr-bot commented May 31, 2022

Rabattkarte commented Jun 3, 2022

minikube-pr-bot commented Jun 3, 2022

minikube-pr-bot commented Jun 3, 2022

spowelljr commented Jun 3, 2022

Rabattkarte commented Jun 4, 2022

minikube-pr-bot commented Jun 4, 2022

minikube-pr-bot commented Jun 4, 2022

k8s-ci-robot commented Jun 6, 2022

linux-foundation-easycla bot commented May 9, 2022 •

edited

Loading