Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO/Kicbase: Update base images #14481

Merged
merged 3 commits into from
Jul 6, 2022
Merged

ISO/Kicbase: Update base images #14481

merged 3 commits into from
Jul 6, 2022
+11 −11

Conversation

spowelljr
Copy link
Member

Updating base images

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2022
@spowelljr
Copy link
Member Author

ok-to-build-image

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 30, 2022
@spowelljr
Copy link
Member Author

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14481/1b18c36/iso_build.txt

@spowelljr
Copy link
Member Author

gluster download is failing, not an ISO issue, reproduced in Chrome

Screen Shot 2022-06-30 at 4 32 34 PM

Will give it another try tomorrow to see if it's a temporary flake

@spowelljr
Copy link
Member Author

ok-to-build-image

@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 1, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14481) |
+----------------+----------+---------------------+
| minikube start | 56.3s    | 56.2s               |
| enable ingress | 27.9s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 55.1s 55.8s 57.5s 57.2s 56.0s
Times for minikube (PR 14481) start: 55.6s 56.1s 56.1s 56.1s 57.0s

Times for minikube ingress: 29.0s 24.6s 28.6s 28.5s 28.6s
Times for minikube (PR 14481) ingress: 29.6s 26.1s 29.6s 25.6s 29.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14481) |
+----------------+----------+---------------------+
| minikube start | 27.6s    | 28.4s               |
| enable ingress | 34.5s    | 35.3s               |
+----------------+----------+---------------------+

Times for minikube start: 27.8s 27.8s 27.6s 27.1s 27.4s
Times for minikube (PR 14481) start: 28.8s 28.3s 28.7s 28.5s 27.6s

Times for minikube ingress: 21.4s 22.4s 22.4s 22.9s 83.4s
Times for minikube (PR 14481) ingress: 22.4s 21.9s 23.4s 82.9s 25.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14481) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 25.3s               |
| enable ingress | 33.4s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 14481) start: 23.1s 22.7s 22.9s 23.6s 34.1s
Times for minikube start: 22.8s 23.5s 23.1s 23.7s 22.5s

Times for minikube ingress: 27.4s 57.9s 27.4s 26.9s 27.4s
Times for minikube (PR 14481) ingress: 26.9s 26.9s 27.4s 27.4s 27.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 0.00 (chart)
none_Linux TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_macOS TestCertExpiration (gopogh) 1.11 (chart)
Docker_macOS TestCertOptions (gopogh) 1.11 (chart)
Docker_macOS TestDockerFlags (gopogh) 1.11 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 1.11 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 1.11 (chart)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 9.30 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 10.00 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 10.00 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 10.00 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 10.00 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 10.00 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 10.00 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 10.71 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 10.71 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 10.71 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 10.71 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member Author

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14481) |
+----------------+----------+---------------------+
| minikube start | 55.8s    | 55.7s               |
| enable ingress | 38.7s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube start: 56.3s 55.1s 54.9s 57.0s 55.6s
Times for minikube (PR 14481) start: 55.8s 55.6s 55.7s 55.3s 56.1s

Times for minikube (PR 14481) ingress: 25.6s 25.1s 29.5s 25.6s 25.6s
Times for minikube ingress: 25.1s 29.6s 28.6s 85.6s 24.6s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14481) |
+-------------------+----------+---------------------+
| minikube start    | 28.0s    | 28.1s               |
| ⚠️  enable ingress | 21.7s    | 33.8s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 27.0s 28.1s 28.6s 27.9s 28.4s
Times for minikube (PR 14481) start: 27.6s 27.7s 28.6s 28.2s 28.5s

Times for minikube ingress: 20.9s 22.9s 21.4s 21.4s 22.0s
Times for minikube (PR 14481) ingress: 21.4s 22.9s 21.9s 81.4s 21.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14481) |
+----------------+----------+---------------------+
| minikube start | 25.8s    | 25.9s               |
| enable ingress | 26.3s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 24.2s 23.8s 33.9s 24.1s
Times for minikube (PR 14481) start: 34.7s 24.0s 24.1s 23.3s 23.2s

Times for minikube ingress: 26.4s 26.4s 26.4s 26.4s 26.1s
Times for minikube (PR 14481) ingress: 26.4s 26.0s 27.4s 26.4s 27.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestNetworkPlugins/group/auto/Start (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/custom-flannel/NetCatPod (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 15.71 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 17.61 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 25.00 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 35.54 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 35.54 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 35.54 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 35.54 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 35.54 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 36.07 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 36.07 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 36.07 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 40.41 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 45.45 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 45.45 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 45.90 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 46.34 (chart)
KVM_Linux TestMultiNode/serial/RestartMultiNode (gopogh) 47.95 (chart)
Docker_Windows TestAddons/Setup (gopogh) 49.62 (chart)
Docker_Windows TestCertExpiration (gopogh) 49.62 (chart)
Docker_Windows TestCertOptions (gopogh) 49.62 (chart)
Docker_Windows TestDockerFlags (gopogh) 49.62 (chart)
Docker_Windows TestForceSystemdEnv (gopogh) 49.62 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 49.62 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 49.62 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 49.62 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 49.62 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 49.62 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 49.62 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 381d0f1 into kubernetes:master Jul 6, 2022
@spowelljr spowelljr deleted the updateBaseImages branch July 6, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prezha prezha Awaiting requested review from prezha

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spowelljr @minikube-bot @k8s-ci-robot @minikube-pr-bot @medyagh