Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dashboard to v2.0.3 #9129

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Update dashboard to v2.0.3 #9129

merged 2 commits into from
Sep 1, 2020

Conversation

tstromberg
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test 
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.3 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.2 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="daa5938ee31fc8d4c71399d103f85736bec5dc26" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v2" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading k8s.io/kubernetes v1.18.5
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading google.golang.org/api v0.25.0
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading k8s.io/apimachinery v0.17.3
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/spf13/viper v1.7.0
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/pkg/errors v0.9.1
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading k8s.io/api v0.17.3
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/google/gofuzz v1.1.0
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading cloud.google.com/go v0.57.0
go: downloading sigs.k8s.io/yaml v1.2.0
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/docker/go-connections v0.4.0
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/docker/go-units v0.4.0
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/google/uuid v1.1.1
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading k8s.io/kube-openapi v0.0.0-20200410145947-61e04a5be9a6
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading go.uber.org/atomic v1.4.0
go: downloading go.uber.org/multierr v1.1.0
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading github.com/pmezard/go-difflib v1.0.0
ok  	k8s.io/minikube/cmd/minikube/cmd	4.585s	coverage: 18.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.045s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.080s	coverage: 52.5% of statements
ok  	k8s.io/minikube/pkg/drivers	0.009s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.012s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.013s	coverage: 3.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.021s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.592s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.109s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.016s	coverage: 100.0% of statements
--- FAIL: TestAuxiliary (0.00s)
    images_test.go:33: images mismatch (-want +got):
          []string{
          	"gcr.io/k8s-minikube/storage-provisioner:v2",
        - 	"kubernetesui/dashboard:v2.0.3",
        + 	"kubernetesui/dashboard:v2.0.1",
          	"kubernetesui/metrics-scraper:v1.0.4",
          }
--- FAIL: TestKubeadmImages (0.00s)
    kubeadm_test.go:113: v1.17.0 images mismatch (-want +got):
          []string{
          	... // 6 identical elements
          	"k8s.gcr.io/kube-scheduler:v1.17.0",
          	"k8s.gcr.io/pause:3.1",
        - 	"kubernetesui/dashboard:v2.0.3",
        + 	"kubernetesui/dashboard:v2.0.1",
          	"kubernetesui/metrics-scraper:v1.0.4",
          }
    kubeadm_test.go:113: v1.15.0 images mismatch (-want +got):
          []string{
          	... // 6 identical elements
          	"k8s.gcr.io/kube-scheduler:v1.15.0",
          	"k8s.gcr.io/pause:3.1",
        - 	"kubernetesui/dashboard:v2.0.3",
        + 	"kubernetesui/dashboard:v2.0.1",
          	"kubernetesui/metrics-scraper:v1.0.4",
          }
    kubeadm_test.go:113: v1.14.0 images mismatch (-want +got):
          []string{
          	... // 6 identical elements
          	"k8s.gcr.io/kube-scheduler:v1.14.0",
          	"k8s.gcr.io/pause:3.1",
        - 	"kubernetesui/dashboard:v2.0.3",
        + 	"kubernetesui/dashboard:v2.0.1",
          	"kubernetesui/metrics-scraper:v1.0.4",
          }
    kubeadm_test.go:113: v1.13.0 images mismatch (-want +got):
          []string{
          	... // 6 identical elements
          	"k8s.gcr.io/kube-scheduler:v1.13.0",
          	"k8s.gcr.io/pause:3.1",
        - 	"kubernetesui/dashboard:v2.0.3",
        + 	"kubernetesui/dashboard:v2.0.1",
          	"kubernetesui/metrics-scraper:v1.0.4",
          }
    kubeadm_test.go:113: v1.12.0 images mismatch (-want +got):
          []string{
          	... // 6 identical elements
          	"k8s.gcr.io/kube-scheduler:v1.12.0",
          	"k8s.gcr.io/pause:3.1",
        - 	"kubernetesui/dashboard:v2.0.3",
        + 	"kubernetesui/dashboard:v2.0.1",
          	"kubernetesui/metrics-scraper:v1.0.4",
          }
FAIL
coverage: 83.1% of statements
FAIL	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.006s
ok  	k8s.io/minikube/pkg/minikube/cluster	0.067s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.021s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.126s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.072s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.047s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.020s	coverage: 33.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.030s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.023s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.029s	coverage: 80.7% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.011s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.040s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.085s	coverage: 36.8% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.043s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.029s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.062s	coverage: 59.3% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.007s	coverage: 54.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.187s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.012s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.009s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.009s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.084s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.012s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.023s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.027s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.646s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.891s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.004s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.006s	coverage: 0.0% of statements
FAIL
Makefile:292: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: 30b1c520-eb4c-11ea-95c6-05b7905ca42d

@TravisBuddy
Copy link

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test 
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.3 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.2 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="50183006423c78f871e99a3d1c9d842efbd516d1" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v2" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading k8s.io/api v0.17.3
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading k8s.io/apimachinery v0.17.3
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading k8s.io/kubernetes v1.18.5
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading cloud.google.com/go v0.57.0
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading sigs.k8s.io/yaml v1.2.0
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/google/gofuzz v1.1.0
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading k8s.io/kube-openapi v0.0.0-20200410145947-61e04a5be9a6
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading github.com/google/go-cmp v0.4.1
go: downloading k8s.io/klog v1.0.0
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/prometheus/common v0.9.1
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/spf13/afero v1.2.2
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading go.uber.org/multierr v1.1.0
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/pmezard/go-difflib v1.0.0
ok  	k8s.io/minikube/cmd/minikube/cmd	4.259s	coverage: 18.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.047s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.099s	coverage: 52.5% of statements
ok  	k8s.io/minikube/pkg/drivers	0.010s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.003s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.016s	coverage: 3.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.045s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.896s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.166s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.026s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.009s	coverage: 83.1% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.064s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.029s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.208s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.048s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.029s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.021s	coverage: 33.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.009s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.019s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.042s	coverage: 80.7% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.007s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.036s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.092s	coverage: 36.8% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.079s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.019s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.068s	coverage: 59.3% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.011s	coverage: 54.5% of statements
2020/08/31 18:16:47 Running: [sh -c echo hi && sleep 3 && echo hey && sleep 1]...
--- FAIL: TestTimeCommandLogs (4.01s)
    logs_test.go:42: expected log "hey" to take more time than it actually did. got 0.998824364, expected > 1
FAIL
coverage: 33.8% of statements
FAIL	k8s.io/minikube/pkg/minikube/perf	4.128s
ok  	k8s.io/minikube/pkg/minikube/problem	0.013s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.009s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.081s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.003s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.026s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.036s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.005s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.664s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.642s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.022s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.004s	coverage: 0.0% of statements
FAIL
Makefile:292: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: 4247abf0-ebb6-11ea-95c6-05b7905ca42d

@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 31, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 65.2s 63.9s 64.4s
Average time for minikube: 64.5s

Times for Minikube (PR 9129): 87.9s 77.2s 82.6s
Average time for Minikube (PR 9129): 82.6s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9129) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 38.7s    | 37.6s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.0 | 23.6s    | 43.1s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.4s     | 0.0s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.1s     | 0.1s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 32.5s 29.2s 29.0s
Average time for minikube: 30.2s

Times for Minikube (PR 9129): 47.3s 46.3s 50.2s
Average time for Minikube (PR 9129): 47.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9129) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.6s     | 9.0s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.0 | 19.4s    | 37.8s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 0.9s     | 0.8s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.0s     | 0.0s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.1s     | 0.1s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

priyawadhwa
priyawadhwa reviewed Sep 1, 2020
View reviewed changes
Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! I think you'll have to increase the preload version as well, since dashboard is currently included in the tarball

https://github.com/kubernetes/minikube/blob/master/pkg/minikube/download/preload.go#L44

@tstromberg tstromberg merged commit d84f87b into kubernetes:master Sep 1, 2020
priyawadhwa pushed a commit to priyawadhwa/minikube that referenced this pull request Sep 2, 2020
Increase preload version to v6
1953f93 
We upgraded the dashboard image in kubernetes#9129, this will rebuild tarballs to include the latest version.

This should also fix a small performance regression, where start time was increased by 25% on kvm2, probably becaues we were waiting for the new dashboard image to download. [PR bot comment](kubernetes#9129 (comment))
@priyawadhwa priyawadhwa mentioned this pull request Sep 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa left review comments

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tstromberg @k8s-ci-robot @TravisBuddy @minikube-pr-bot @priyawadhwa