Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unlabeled test lane #33827

Open
kannon92 opened this issue Nov 21, 2024 · 4 comments
Open

Drop unlabeled test lane #33827

kannon92 opened this issue Nov 21, 2024 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@kannon92
Copy link
Contributor

What would you like to be added:

https://testgrid.k8s.io/sig-node-cri-o#ci-crio-cgroupv1-node-e2e-unlabelled

These jobs are a grabbag of all incorrectly labeled tests. We should label these tests and eventually drop this test lane.

Why is this needed:

Many of these tests could be considered conformance and having a non standard labeling is a bit confusing.

@kannon92 kannon92 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 21, 2024
@kannon92
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 23, 2024
@kannon92 kannon92 moved this from Triage to Issues - To do in SIG Node CI/Test Board Dec 4, 2024
@SergeyKanzhelev
Copy link
Member

The idea here is to label as many tests as we can with either NodeConformance or Ferature label. Once all labeled we can changer periodicity of this lane to once in a few days to pick up any unlabeled tests.

For example, add NodeConformance to E2eNode Suite.[It] [sig-node] Probing container should be restarted by liveness probe after startup probe enables it.

@SergeyKanzhelev
Copy link
Member

/help

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
Status: Issues - To do
Development

No branches or pull requests

3 participants