Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sigmention plugin needs to be more configurable #6217

Merged
merged 1 commit into from
Jan 11, 2018
Merged

sigmention plugin needs to be more configurable #6217

merged 1 commit into from
Jan 11, 2018

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Jan 10, 2018 •
edited
Loading

Tested and it's working as expected now. We don't use specialized teams in Openshift.

@0xmichalis 0xmichalis requested a review from cjwagner as a code owner January 10, 2018 15:03
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2018
@0xmichalis 0xmichalis mentioned this pull request Jan 10, 2018
Merged
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2018
cjwagner
cjwagner reviewed Jan 10, 2018
View reviewed changes
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we are repeating team mentions if the user is not a member of the org in which they are commenting. https://github.com/kargakis/test-infra/blob/86173c580e4f7eb436d01b31255eebedde1e3466/prow/plugins/sigmention/sigmention.go#L140
I think we actually need to check if the user is a member of the owning org? I couldn't find Github documentation about this though.
This LGTM though.
/lgtm
/hold

prow/plugins/plugins.go Outdated
OwningOrg string `json:"owning_org,omitempty"`
// Regexp parses comments and should return matches to team mentions.
// These mentions enable labeling issues or PRs with sig/team labels.
// Furthermore, teams with the following prefixes will be mapped to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/prefixes/suffixes/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, kargakis

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@0xmichalis
Copy link
Contributor Author

@cjwagner agreed on changing the membership check; opened #6251

@0xmichalis
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit a4f4b89 into kubernetes:master Jan 11, 2018
@0xmichalis 0xmichalis deleted the sigmention-again branch January 11, 2018 09:44
@0xmichalis 0xmichalis mentioned this pull request Jan 11, 2018
Closed
@0xmichalis
Copy link
Contributor Author

Works for us now: openshift/origin#18059 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner cjwagner left review comments

Assignees

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xmichalis @k8s-ci-robot @cjwagner