Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Milvus Standalone to documentation #29650

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

markperfect
Copy link
Contributor

@markperfect markperfect commented Feb 6, 2025

  • PR title:

  • PR message:

    • Added a new section for how to set up and use Milvus with Docker, and added an example of how to instantiate Milvus for hybrid retrieval
    • Fixed the documentation setup to run make lint and make format
  • Add tests and docs: If you're adding a new integration, please include
    N/A

  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 2:59pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Feb 6, 2025
@efriis
Copy link
Contributor

efriis commented Feb 7, 2025

cc @zc277584121

@markperfect
Copy link
Contributor Author

@efriis all checks have passed

@zc277584121
Copy link
Contributor

@efriis lgtm , @markperfect thank you for your great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

3 participants