Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(ci): run lint and tests in parallel #2736

Closed
wants to merge 16 commits into from

Conversation

robertylewis
Copy link
Member

Actions doesn't let us run steps in parallel, but we can run jobs in parallel. The lint and test jobs are part of the same workflow. Understanding Actions terminology is half the battle.

@gebner
Copy link
Member

gebner commented May 18, 2020

  • We need to tell bors about the new CI jobs.
  • Can we maybe retire the "upload precompiled mathlib zip file" step now if the first job generates an artifact anyhow?

@gebner
Copy link
Member

gebner commented May 18, 2020

  • Installing the python dependencies should be moved to the documentation generation job.

@gebner
Copy link
Member

gebner commented May 18, 2020

Apparently the zip file doesn't preserve the permissions. We probably need to switch to "precompiled tar.gz".

@bryangingechen
Copy link
Collaborator

Apparently the zip file doesn't preserve the permissions. We probably need to switch to "precompiled tar.gz".

Yeah, that looks like it's tracked here: actions/upload-artifact#38

@bryangingechen
Copy link
Collaborator

bryangingechen commented May 18, 2020

  • We need to tell bors about the new CI jobs.

Done.

  • Can we maybe retire the "upload precompiled mathlib zip file" step now if the first job generates an artifact anyhow?

I don't understand. Isn't that the step that generates and uploads the artifact?

Apparently the zip file doesn't preserve the permissions. We probably need to switch to "precompiled tar.gz".

I just added a bunch more chmod +x's for now. I'll look into taring before generating the artifact after dinner.

Done.

@bryangingechen
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request May 18, 2020
@bors
Copy link

bors bot commented May 18, 2020

try

Build succeeded:

@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 19, 2020
bors bot pushed a commit that referenced this pull request May 19, 2020
Actions doesn't let us run *steps* in parallel, but we can run *jobs* in parallel. The lint and test jobs are part of the same *workflow*. Understanding Actions terminology is half the battle.

Co-authored-by: Rob Lewis <[email protected]>
Co-authored-by: Bryan Gin-ge Chen <[email protected]>
@bors
Copy link

bors bot commented May 19, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ci): run lint and tests in parallel [Merged by Bors] - feat(ci): run lint and tests in parallel May 19, 2020
@bors bors bot closed this May 19, 2020
@bors bors bot deleted the ci-parallel branch May 19, 2020 04:06
@gebner
Copy link
Member

gebner commented May 19, 2020

  • Can we maybe retire the "upload precompiled mathlib zip file" step now if the first job generates an artifact anyhow?

I don't understand. Isn't that the step that generates and uploads the artifact?

Sorry, I missed that at first. I thought github actions has some built-in support to save the current directory.

b-mehta pushed a commit that referenced this pull request May 20, 2020
Actions doesn't let us run *steps* in parallel, but we can run *jobs* in parallel. The lint and test jobs are part of the same *workflow*. Understanding Actions terminology is half the battle.

Co-authored-by: Rob Lewis <[email protected]>
Co-authored-by: Bryan Gin-ge Chen <[email protected]>
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
Actions doesn't let us run *steps* in parallel, but we can run *jobs* in parallel. The lint and test jobs are part of the same *workflow*. Understanding Actions terminology is half the battle.

Co-authored-by: Rob Lewis <[email protected]>
Co-authored-by: Bryan Gin-ge Chen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants