feat(core)!: drop Python 3.8 support #4010
Open
+1,373
−1,930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/asgi
area/background-tasks
area/channels
area/ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3.0 #4010 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 342 342
Lines 15390 15414 +24
Branches 1667 1666 -1
=======================================
+ Hits 15123 15147 +24
+ Misses 133 132 -1
- Partials 134 135 +1 ☔ View full report in Codecov by Sentry. |
|
provinzkraut
force-pushed
the
drop-38
branch
from
058efba to
4d36e24
Compare
sobolevn
reviewed
Feb 16, 2025
provinzkraut
force-pushed
the
drop-38
branch
from
4d36e24 to
ff400a3
Compare
cofin
reviewed
Feb 22, 2025
| @@ -8,7 +8,7 @@ | |||
| from litestar.plugins.sqlalchemy import SQLAlchemyDTO | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from typing import List | |||
| pass | |||
There was a problem hiding this comment.
I think we can just remove the entire block
There was a problem hiding this comment.
Yeah, no idea why ruff doesn't do these automatically?
cofin
reviewed
Feb 22, 2025
| @@ -8,7 +8,7 @@ | |||
| from litestar.plugins.sqlalchemy import SQLAlchemySerializationPlugin | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from typing import List | |||
| pass | |||
|
|
|||
There was a problem hiding this comment.
I think we can remove the TYPE_CHECKING import
cofin
reviewed
Feb 22, 2025
| @@ -9,7 +9,7 @@ | |||
| from litestar.plugins.sqlalchemy import SQLAlchemySerializationPlugin | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from typing import List | |||
| pass | |||
cofin
reviewed
Feb 22, 2025
| @@ -8,7 +8,7 @@ | |||
| from litestar.plugins.sqlalchemy import SQLAlchemySerializationPlugin | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from typing import List | |||
| pass | |||
cofin
reviewed
Feb 22, 2025
| @@ -9,7 +9,7 @@ | |||
| from litestar.plugins.sqlalchemy import SQLAlchemySerializationPlugin | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from typing import List | |||
| pass | |||
cofin
reviewed
Feb 22, 2025
| @@ -281,8 +277,8 @@ def _validate_handler_function(self) -> None: | |||
| async def default_connection_lifespan( | |||
| self, | |||
| socket: WebSocket, | |||
| on_accept_dependencies: Optional[Dict[str, Any]] = None, # noqa: UP006, UP007 | |||
| on_disconnect_dependencies: Optional[Dict[str, Any]] = None, # noqa: UP006, UP007 | |||
| on_accept_dependencies: Optional[dict[str, Any]] = None, # noqa: UP007 | |||
There was a problem hiding this comment.
Should we remove UP007 and the Optional as well?
There was a problem hiding this comment.
Sure because Python 3.8 also have support of | operator as Union, we can use SomeType | None.
cofin
reviewed
Feb 22, 2025
euri10
reviewed
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for Python 3.8.
How to review this?
This is a rather big PR, however, almost all changes have been made automatically by ruff. I've put those into separate commits, so I suggest reviewing the commits not consisting of ruff changes individually.