Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored tests into 24 separate tests #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HJLebbink
Copy link
Member

@HJLebbink HJLebbink commented Feb 13, 2025

Note: depends on #114

Refactored one large test into separate tests. It runs 2 twice as fast as a result

@HJLebbink HJLebbink added the enhancement New feature or request label Feb 13, 2025
@HJLebbink HJLebbink force-pushed the update-tests branch 2 times, most recently from 533bf80 to 08fd05c Compare February 13, 2025 09:43
@HJLebbink HJLebbink requested review from donatello and balamurugana and removed request for donatello February 13, 2025 09:53
@HJLebbink HJLebbink marked this pull request as ready for review February 13, 2025 09:58
@HJLebbink HJLebbink marked this pull request as draft February 13, 2025 11:01
@HJLebbink HJLebbink marked this pull request as ready for review February 13, 2025 12:07
@donatello
Copy link
Member

Please fix conflicts @HJLebbink

@HJLebbink
Copy link
Member Author

Please fix conflicts @HJLebbink

@donatello I rebased. Two minor issues with the code.

  1. Every test is responsible for removing the stuff it created. But if the test fails the remove_bucket_helper may not be called.
  2. TestContext.new_from_env (that reads the environment variables) only works with the configuration used by the build server. For a setup with play.min.io or my local box, it has bugs reading the env variables. A fixed version TestContex.new_from_env_new fixes that, but it does not work on with the build server.

@HJLebbink
Copy link
Member Author

@donatello

I fixed that tests may not always cleanup their stuff.

PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants