Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec: check cdi manager not nil #5729

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

crazy-max
Copy link
Member

fixes #5724

@crazy-max crazy-max requested a review from tonistiigi February 12, 2025 12:33
@crazy-max crazy-max added this to the v0.20.0 milestone Feb 12, 2025
@tonistiigi
Copy link
Member

    --- FAIL: TestExecOpCacheMap/empty (0.00s)
	github.com/moby/buildkit/solver/llbsolver/provenance		coverage: 0.0% of statements
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xcfb8f2]

goroutine 19 [running]:
testing.tRunner.func1.2({0xdf7a60, 0x1711e60})
	/usr/local/go/src/testing/testing.go:1632 +0x230
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1635 +0x35e
panic({0xdf7a60?, 0x1711e60?})
	/usr/local/go/src/runtime/panic.go:785 +0x132
github.com/moby/buildkit/solver/llbsolver/ops.(*ExecOp).CacheMap(0xc00039e000, {0xc000383680?, 0x5af9cd?}, {0x15304f8?, 0x1111d2c?}, 0xf?)
	/src/solver/llbsolver/ops/exec.go:202 +0xa52
github.com/moby/buildkit/solver/llbsolver/ops.TestExecOpCacheMap.func1(0xc00039a1a0)
	/src/solver/llbsolver/ops/exec_test.go:114 +0xf3
testing.tRunner(0xc00039a1a0, 0xc00038e2c0)
	/usr/local/go/src/testing/testing.go:1690 +0xf4
created by testing.(*T).Run in goroutine 18
	/usr/local/go/src/testing/testing.go:1743 +0x390
?   	github.com/moby/buildkit/solver/llbsolver/provenance/types	[no test files]

@tonistiigi tonistiigi merged commit fa8de09 into moby:master Feb 13, 2025
105 checks passed
@crazy-max crazy-max deleted the cdi-handle-nil branch February 13, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v0.20] Nil CDI manager can cause errors
2 participants