Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: update runc to 1.2.5 #5741

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

austinvazquez
Copy link
Contributor

This is the fifth patch release in the 1.2.z series of runc. It primarily fixes an issue caused by an upstream systemd bug.

  • There was a regression in systemd v230 which made the way we define device rule restrictions require a systemctl daemon-reload for our transient units. This caused issues for workloads using NVIDIA GPUs. Workaround the upstream regression by re-arranging how the unit properties are defined.
  • Dependency github.com/cyphar/filepath-securejoin is updated to v0.4.1, to allow projects that vendor runc to bump it as well.
  • CI: fixed criu-dev compilation.
  • Dependency golang.org/x/net is updated to 0.33.0.

diff: opencontainers/[email protected]

Signed-off-by: Austin Vazquez <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazy-max
crazy-max previously approved these changes Feb 18, 2025
@crazy-max crazy-max dismissed their stale review February 18, 2025 12:03

test failure

@crazy-max
Copy link
Member

crazy-max commented Feb 18, 2025

https://github.com/moby/buildkit/actions/runs/13322251713/job/37392787599?pr=5741

Rootless integration seems to time out with runc 1.2.5 https://github.com/moby/buildkit/actions/runs/13322251713/job/37392787599?pr=5741 (whole test suite takes around 7 minutes usually)

Looks to be on TestClientGatewayIntegration/TestClientGatewayContainerHostNetworkingValidation/worker=containerd-rootless/netmode=host: https://github.com/moby/buildkit/actions/runs/13322251713/job/37392787599?pr=5741#step:8:1201.

@crazy-max
Copy link
Member

Rootless integration seems to time out with runc 1.2.5 https://github.com/moby/buildkit/actions/runs/13322251713/job/37392787599?pr=5741 (whole test suite takes around 7 minutes usually)

Looks to be on TestClientGatewayContainerHostNetworkingValidation: https://github.com/moby/buildkit/actions/runs/13322251713/job/37392787599?pr=5741#step:8:1201.

Looks good after re-run of the job but we should keep an eye on it.

@crazy-max crazy-max merged commit 13c7eaa into moby:master Feb 18, 2025
105 checks passed
@austinvazquez austinvazquez deleted the update-runc-1.2.5 branch February 18, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants