-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use loadDelay
generator setting in subscriptions as well
#6918
Conversation
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/14/2023 07:03:40pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 8673f96 Started: 08/14/2023 07:01:27pm UTC Current Playwright Test Results Summary✅ 133 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/14/2023 07:03:40pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0.84% (1)1 / 119 runfailed over last 7 days |
42.02% (50)50 / 119 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 117 runsfailed over last 7 days |
41.88% (49)49 / 117 runsflaked over last 7 days |
📄 functional/plugins/plot/tagging.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Plot Tagging Tags work with Overlay Plots
Retry 2 • Retry 1 • Initial Attempt |
10.26% (12)12 / 117 runsfailed over last 7 days |
25.64% (30)30 / 117 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6918 +/- ##
==========================================
- Coverage 48.37% 48.35% -0.03%
==========================================
Files 643 643
Lines 25627 25627
Branches 2496 2496
==========================================
- Hits 12397 12391 -6
- Misses 12755 12760 +5
- Partials 475 476 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can just add a few more comments to the reasoning behind the assertions
Closes #6917
Describe your changes:
Uses the
loadDelay
value specified on Sine Wave Generators to delay its realtime data in addition to historical requests. Vue 3 improved reactivity is causing the conditionSet to update when the SWG receives new realtime data, which was happening instantly because we weren't delaying realtime data. This fixes the e2e test and correctly tests the case where telemetry is not outputting data.All Submissions:
Author Checklist
Reviewer Checklist