Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use loadDelay generator setting in subscriptions as well #6918

Merged
merged 16 commits into from
Aug 14, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Aug 10, 2023

Closes #6917

Describe your changes:

Uses the loadDelay value specified on Sine Wave Generators to delay its realtime data in addition to historical requests. Vue 3 improved reactivity is causing the conditionSet to update when the SWG receives new realtime data, which was happening instantly because we weren't delaying realtime data. This fixes the e2e test and correctly tests the case where telemetry is not outputting data.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:3.1.0 milestone Aug 10, 2023
@deploysentinel
Copy link

deploysentinel bot commented Aug 10, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/14/2023 07:03:40pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 8673f96

Started: 08/14/2023 07:01:27pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 133 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/14/2023 07:03:40pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 8673f96

Started: 08/14/2023 06:49:10pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0.84% (1) 1 / 119 run
failed over last 7 days
42.02% (50) 50 / 119 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 117 runs
failed over last 7 days
41.88% (49) 49 / 117 runs
flaked over last 7 days

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots
Retry 2Retry 1Initial Attempt
10.26% (12) 12 / 117 runs
failed over last 7 days
25.64% (30) 30 / 117 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #6918 (8673f96) into master (f3b819a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6918      +/-   ##
==========================================
- Coverage   48.37%   48.35%   -0.03%     
==========================================
  Files         643      643              
  Lines       25627    25627              
  Branches     2496     2496              
==========================================
- Hits        12397    12391       -6     
- Misses      12755    12760       +5     
- Partials      475      476       +1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.08% <ø> (-0.01%) ⬇️ Carriedforward from 745880d
e2e-stable 57.13% <100.00%> (+0.55%) ⬆️
unit 38.75% <33.33%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
example/generator/WorkerInterface.js 97.67% <100.00%> (ø)
src/plugins/condition/ConditionManager.js 63.63% <100.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b819a...8673f96. Read the comment docs.

@khalidadil khalidadil self-requested a review August 11, 2023 18:32
Copy link
Contributor

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can just add a few more comments to the reasoning behind the assertions

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 14, 2023
@ozyx ozyx enabled auto-merge (squash) August 14, 2023 18:57
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 14, 2023
@ozyx ozyx merged commit 57743e5 into master Aug 14, 2023
@ozyx ozyx deleted the fix-conditionSet-test branch August 14, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] FLAKE: conditionSet - ConditionSet should output blank instead of the default value
4 participants