Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#7121): Do not store state in singleton action #7134

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

akhenry
Copy link
Contributor

@akhenry akhenry commented Oct 10, 2023

Cherry picks #7121 to fix #7089

@akhenry akhenry changed the base branch from master to release/3.1.0 October 10, 2023 23:07
@akhenry akhenry requested a review from ozyx October 10, 2023 23:08
@ozyx ozyx added this to the Target:3.1.0 milestone Oct 10, 2023
@ozyx ozyx enabled auto-merge (squash) October 10, 2023 23:09
@deploysentinel
Copy link

deploysentinel bot commented Oct 10, 2023

Current Playwright Test Results Summary

✅ 141 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/10/2023 11:17:20pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: cfbb097

Started: 10/10/2023 11:10:03pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
4.82% (4) 4 / 83 runs
failed over last 7 days
33.73% (28) 28 / 83 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
3.75% (3) 3 / 80 runs
failed over last 7 days
36.25% (29) 29 / 80 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 75 runs
failed over last 7 days
34.67% (26) 26 / 75 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
1.74% (2) 2 / 115 runs
failed over last 7 days
60% (69) 69 / 115 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
5.95% (5) 5 / 84 runs
failed over last 7 days
57.14% (48) 48 / 84 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx merged commit c1dd82c into release/3.1.0 Oct 10, 2023
@ozyx ozyx deleted the cherry-pick-7121 branch October 10, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json should be sanitized on import
4 participants