[chore] clean up revive configuration #6353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
|
/cc @pellared |
mmorel-35
changed the title
mmorel-35
force-pushed
the
cleanup/golangci-lint
branch
2 times, most recently
from
7d7a19f to
44c5f53
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6353 +/- ##
=======================================
- Coverage 81.8% 81.8% -0.1%
=======================================
Files 283 283
Lines 24900 24900
=======================================
- Hits 20387 20386 -1
- Misses 4109 4110 +1
Partials 404 404 |
pellared
reviewed
Feb 21, 2025
mmorel-35
force-pushed
the
cleanup/golangci-lint
branch
from
44c5f53 to
d5d355b
Compare
pellared
changed the title
mmorel-35
force-pushed
the
cleanup/golangci-lint
branch
3 times, most recently
from
7f3d064 to
a954f93
Compare
pellared
reviewed
Feb 21, 2025
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
cleanup/golangci-lint
branch
from
a954f93 to
54b2163
Compare
pellared
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Side note from https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md#how-to-send-pull-requests:
Avoid rebasing and force-pushing to your branch to facilitate reviewing the pull request. Rewriting Git history makes it difficult to keep track of iterations during code review. All pull requests are squashed to a single commit upon merge to
main.
dmathieu
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #6273 (review)
This clean up revive configuration