Drop extended_networking_minimal #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
|
@danwinship can you also delete references to it in |
|
@danwinship can you rebase and I'll merge? |
danwinship
force-pushed
the
drop-networking-minimal
branch
from
4c51ff4 to
01635ab
Compare
|
@stevekuznetsov done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the merge of openshift/openshift-ansible#7373 we now seem to be successfully using the NetworkPolicy in the GCE tests (eg https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/test_branch_origin_extended_conformance_gce/2669/), so extended_networking_minimal is pretty redundant, and since it's currently disabled anyway due to dind-related flaking, we should just kill it. (We still need the full extended_networking test to exist, so we can test all three networking plugins when needed, but we should eventually port that to use ansible rather than dind.)
I don't know the details of how CI works so I don't know if this PR is right at all...