add OOMKilled failure reason to build #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
lgtm. @openshift/api-review should be a quick review and i would guess merge order does not matter on this one either. |
liggitt
reviewed
Jul 12, 2018
build/v1/consts.go
Outdated
| @@ -84,6 +84,9 @@ const ( | |||
| // range of build failures. | |||
| StatusReasonGenericBuildFailed StatusReason = "GenericBuildFailed" | |||
|
|
|||
| // StatusReasonOOMKilled indicates that the build pod was killed for its memory consumption | |||
| StatusReasonOOMKilled StatusReason = "OOMKilled" | |||
There was a problem hiding this comment.
if this is net new, write out "OutOfMemory"? seems fine otherwise
There was a problem hiding this comment.
updated with the longer version, if this is ok, I will update the origin PR as well
wozniakjan
force-pushed
the
bug-1596440/surface_oomkilled_in_build
branch
from
70400c3 to
d38fb28
Compare
|
/lgtm |
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/api
that referenced
this pull request
Feb 1, 2021
Default containerPort to 443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for openshift/origin#20297
ptal @openshift/sig-developer-experience , @openshift/api-review