Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.11] NO-ISSUE: Increase image pull timeout during install #906

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #905

/assign openshift-cherrypick-robot

/cherrypick release-4.18 release-4.17 release-4.16

Previously, there was a timeout of 30 seconds when
pulling the installer image. This is not enough
time to pull the image and to mark the installation
as failed.

This change increases the timeout to 600 seconds
(10 minutes), which is more accurate for a failed
image pull. The error message from failing to pull
has also been updated to reflect the actual failure.
@openshift-ci openshift-ci bot requested review from eifrach and romfreiman February 5, 2025 21:18
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.75%. Comparing base (b9132b1) to head (c443fb0).
Report is 1 commits behind head on release-ocm-2.11.

Files with missing lines Patch % Lines
src/commands/actions/install_cmd.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.11     #906      +/-   ##
====================================================
- Coverage             59.80%   59.75%   -0.06%     
====================================================
  Files                    74       74              
  Lines                  3712     3712              
====================================================
- Hits                   2220     2218       -2     
- Misses                 1335     1336       +1     
- Partials                157      158       +1     
Files with missing lines Coverage Δ
src/commands/actions/install_cmd.go 75.14% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

openshift-ci bot commented Feb 5, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gamli75
Copy link
Contributor

gamli75 commented Feb 6, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2025
@openshift-ci-robot
Copy link

@gamli75: This pull request explicitly references no jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 580b721 into openshift:release-ocm-2.11 Feb 6, 2025
7 checks passed
@openshift-cherrypick-robot
Copy link
Author

@openshift-cherrypick-robot: new pull request created: #907

In response to this:

This is an automated cherry-pick of #905

/assign openshift-cherrypick-robot

/cherrypick release-4.18 release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants