Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19420: Replace HighAvailabilityMode with ControlPlaneCount #911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrej1991
Copy link

@andrej1991 andrej1991 commented Feb 14, 2025

MGMT-19420: Replace HighAvailabilityMode with ControlPlaneCount. It is the first phase. Now in the install parameters it still accepts the high-availability-mode just it translates the parameter to control-plane-count in the following maner:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2025
Copy link

openshift-ci bot commented Feb 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@andrej1991
Copy link
Author

/cc: @danmanor

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2025
@andrej1991 andrej1991 force-pushed the aantal-MGMT-19420 branch 2 times, most recently from 9194e3a to 3448c65 Compare February 18, 2025 11:21
@andrej1991 andrej1991 marked this pull request as ready for review February 18, 2025 11:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.60%. Comparing base (3e2184b) to head (7cde2e3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/commands/actions/install_cmd.go 60.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   60.52%   60.60%   +0.07%     
==========================================
  Files          75       75              
  Lines        4008     4044      +36     
==========================================
+ Hits         2426     2451      +25     
- Misses       1411     1421      +10     
- Partials      171      172       +1     
Files with missing lines Coverage Δ
src/commands/actions/install_cmd.go 74.01% <60.00%> (-1.43%) ⬇️

... and 1 file with indirect coverage changes

@danmanor
Copy link
Contributor

/approve cancel

@danmanor
Copy link
Contributor

/remove-approve

@danmanor
Copy link
Contributor

/lgtm cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 19, 2025
@andrej1991 andrej1991 force-pushed the aantal-MGMT-19420 branch 2 times, most recently from aa95253 to b573f69 Compare February 20, 2025 08:27
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
Copy link

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrej1991, danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@andrej1991
Copy link
Author

/retest

@danmanor
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@danmanor: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andrej1991 andrej1991 changed the title Replace HighAvailabilityMode with ControlPlaneCount MGMT-19420: Replace HighAvailabilityMode with ControlPlaneCount Feb 20, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2025

@andrej1991: This pull request references MGMT-19420 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

MGMT-19420: Replace HighAvailabilityMode with ControlPlaneCount. It is the first phase. Now in the install parameters it still accepts the high-availability-mode just it translates the parameter to control-plane-count in the following maner:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andrej1991
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2025

@andrej1991: This pull request references MGMT-19420 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 93697bb and 2 for PR HEAD 7cde2e3 in total

@danmanor
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Feb 21, 2025

@andrej1991: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 7cde2e3 link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants