-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19420: Replace HighAvailabilityMode with ControlPlaneCount #911
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
/cc: @danmanor |
9194e3a
to
3448c65
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #911 +/- ##
==========================================
+ Coverage 60.52% 60.60% +0.07%
==========================================
Files 75 75
Lines 4008 4044 +36
==========================================
+ Hits 2426 2451 +25
- Misses 1411 1421 +10
- Partials 171 172 +1
|
/approve cancel |
/remove-approve |
/lgtm cancel |
aa95253
to
b573f69
Compare
b573f69
to
7cde2e3
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrej1991, danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/jira refresh |
@danmanor: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@andrej1991: This pull request references MGMT-19420 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@andrej1991: This pull request references MGMT-19420 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
@andrej1991: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
MGMT-19420: Replace HighAvailabilityMode with ControlPlaneCount. It is the first phase. Now in the install parameters it still accepts the high-availability-mode just it translates the parameter to control-plane-count in the following maner:
This PR is dependent on MGMT-19421: phase 1 of replacing the refference HighAvailabilityMode with ControlPlaneCount assisted-installer#1027