OCPBUGS-43748: etcd pod containers do not start when tls min version is 1.3

[sanchezl]

• add ETCD_TLS_MIN_VERSION env to etcd pods
• add listen-tls-min-version flag to readyz cmd
• do not start etcd with --cipher-suites with tls1.3

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tjungblu]

haha nice trick

[tjungblu]

looks good to me, tests are failing though

[tjungblu]

/lgtm

I think you just have to update the assertions to have the env var added

[openshift-ci-robot]

@sanchezl: This pull request references Jira Issue OCPBUGS-43748, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• add ETCD_TLS_MIN_VERSION env to etcd pods
• add listen-tls-min-version flag to readyz cmd
• do not start etcd with --cipher-suites with tls1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9a2aa20 and 2 for PR HEAD b2ec0b7 in total

[tjungblu]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanchezl, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tjungblu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9a2aa20 and 2 for PR HEAD c66a71f in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9a2aa20 and 2 for PR HEAD c66a71f in total

[openshift-ci]

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	c66a71f	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown	c66a71f	link	false	/test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery	c66a71f	link	false	/test e2e-aws-etcd-recovery
ci/prow/e2e-aws-etcd-certrotation	c66a71f	link	false	/test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown	c66a71f	link	false	/test e2e-metal-ovn-sno-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[geliu2016]

/label cherry-pick-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a053e7c and 2 for PR HEAD c66a71f in total

[openshift-ci-robot]

@sanchezl: Jira Issue OCPBUGS-43748: All pull requests linked via external trackers have merged:

• openshift/cluster-etcd-operator#1364

Jira Issue OCPBUGS-43748 has been moved to the MODIFIED state.

In response to this:

• add ETCD_TLS_MIN_VERSION env to etcd pods
• add listen-tls-min-version flag to readyz cmd
• do not start etcd with --cipher-suites with tls1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator
This PR has been included in build cluster-etcd-operator-container-v4.19.0-202411260335.p0.g47b36cf.assembly.stream.el9.
All builds following this will include this PR.

[wangke19]

/cherry-pick release-4.18

[openshift-cherrypick-robot]

@wangke19: #1364 failed to apply on top of branch "release-4.18":

Applying: ensure etcd starts when using TLS1.3
Using index info to reconstruct a base tree...
M	bindata/etcd/pod.gotpl.yaml
M	pkg/etcdenvvar/envvarcontroller_test.go
M	pkg/operator/etcd_assets/bindata.go
M	pkg/operator/targetconfigcontroller/targetconfigcontroller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/targetconfigcontroller/targetconfigcontroller.go
CONFLICT (content): Merge conflict in pkg/operator/targetconfigcontroller/targetconfigcontroller.go
Auto-merging pkg/operator/etcd_assets/bindata.go
Auto-merging pkg/etcdenvvar/envvarcontroller_test.go
Auto-merging bindata/etcd/pod.gotpl.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 ensure etcd starts when using TLS1.3

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.