Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: Remove etcd gRPC calls failed alerts #340

Merged

Conversation

brancz
Copy link
Contributor

@brancz brancz commented Apr 30, 2019

These alerts are firing constantly due to some issues around how to etcd
increases its metrics. See etcd-io/etcd#10289

@metalmatze @squat @s-urbaniak @paulfantom @mxinden

These alerts are firing constantly due to some issues around how to etcd
increases its metrics. See etcd-io/etcd#10289
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
Copy link
Contributor

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
😿

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brancz
Copy link
Contributor Author

brancz commented Apr 30, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit e467a57 into openshift:master Apr 30, 2019
@brancz brancz deleted the remove-etcd-grpc-failed-alerts branch May 2, 2019 09:11
@pierreozoux
Copy link

I'm using OpenShift 3.11, do you know when this will land there?
I just want to make sure it will land with the next version of OpenShift.

@zhigwang
Copy link

I have the same question, when will this fix be available to use in production (3.11)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants