Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7726,ODC-7767: Expose Topology components and utils to openshift-console/dynamic-plugin-sdk #14705

Conversation

lokanandaprabhu
Copy link
Contributor

@lokanandaprabhu lokanandaprabhu commented Jan 30, 2025

Story:

https://issues.redhat.com/browse/ODC-7726
https://issues.redhat.com/browse/ODC-7767

Description:

Exposing the below topology components to dynamic plugins,

CpuCellComponent
MemoryCellComponent
TopologyListViewNode
useOverviewMetrics
withEditReviewAccess
getPodMetricStats
getTopologyResourceObject
getResource
getTopologyEdgeItems
getTopologyGroupItems
getTopologyNodeItem
mergeGroup
getModifyApplicationAction
baseDataModelGetter
getWorkloadResources
contextMenuActions
CreateConnector
createConnectorCallback 

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2025

@lokanandaprabhu: This pull request references ODC-7767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Story:

https://issues.redhat.com/browse/ODC-7767

Description:

Exposing the below topology components to dynamic plugins,

getModifyApplicationAction
baseDataModelGetter
getWorkloadResources
contextMenuActions
CreateConnector
createConnectorCallback 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/helm Related to helm-plugin component/knative Related to knative-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology labels Jan 30, 2025
@lokanandaprabhu
Copy link
Contributor Author

/retest

@lokanandaprabhu
Copy link
Contributor Author

/cc @vikram-raj @vojtechszocs

@vikram-raj
Copy link
Member

/retest

@rhamilto
Copy link
Member

/lgtm

/hold for #14621 to merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2025
@lokanandaprabhu
Copy link
Contributor Author

/retest

@logonoff
Copy link
Member

logonoff commented Feb 6, 2025

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2025
@lokanandaprabhu lokanandaprabhu force-pushed the feature/topology-componets-exposed-to-DP-phase-2 branch from 62ca8ef to 93774aa Compare February 6, 2025 04:48
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2025
@lokanandaprabhu lokanandaprabhu force-pushed the feature/topology-componets-exposed-to-DP-phase-2 branch from 93774aa to a35a6e5 Compare February 6, 2025 04:52
@lokanandaprabhu
Copy link
Contributor Author

/retest

@rhamilto
Copy link
Member

rhamilto commented Feb 6, 2025

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
@rhamilto
Copy link
Member

rhamilto commented Feb 6, 2025

/retest

@yapei
Copy link
Contributor

yapei commented Feb 7, 2025

Screenshot 2025-02-07 at 11 57 26 AM /label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2025

@lokanandaprabhu: This pull request references ODC-7767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Story:

https://issues.redhat.com/browse/ODC-7767

Description:

Exposing the below topology components to dynamic plugins,

getModifyApplicationAction
baseDataModelGetter
getWorkloadResources
contextMenuActions
CreateConnector
createConnectorCallback 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
@lokanandaprabhu
Copy link
Contributor Author

Removed Example Topology page from demo dynamic plugin since topology components are exposed in internal package.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2025

@lokanandaprabhu: This pull request references ODC-7767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Story:

https://issues.redhat.com/browse/ODC-7767

Description:

Exposing the below topology components to dynamic plugins,

CpuCellComponent
MemoryCellComponent
TopologyListViewNode
useOverviewMetrics
withEditReviewAccess
getPodMetricStats
getTopologyResourceObject
getResource
getTopologyEdgeItems
getTopologyGroupItems
getTopologyNodeItem
mergeGroup
getModifyApplicationAction
baseDataModelGetter
getWorkloadResources
contextMenuActions
CreateConnector
createConnectorCallback 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2025

@lokanandaprabhu: This pull request references ODC-7767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Story:

https://issues.redhat.com/browse/ODC-7726
https://issues.redhat.com/browse/ODC-7767

Description:

Exposing the below topology components to dynamic plugins,

CpuCellComponent
MemoryCellComponent
TopologyListViewNode
useOverviewMetrics
withEditReviewAccess
getPodMetricStats
getTopologyResourceObject
getResource
getTopologyEdgeItems
getTopologyGroupItems
getTopologyNodeItem
mergeGroup
getModifyApplicationAction
baseDataModelGetter
getWorkloadResources
contextMenuActions
CreateConnector
createConnectorCallback 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lokanandaprabhu lokanandaprabhu changed the title ODC-7767: Expose remaining Topology components and utils to openshift-console/dynamic-plugin-sdk ODC-7726,ODC-7767: Expose remaining Topology components and utils to openshift-console/dynamic-plugin-sdk Feb 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2025

@lokanandaprabhu: This pull request references ODC-7726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

This pull request references ODC-7767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Story:

https://issues.redhat.com/browse/ODC-7726
https://issues.redhat.com/browse/ODC-7767

Description:

Exposing the below topology components to dynamic plugins,

CpuCellComponent
MemoryCellComponent
TopologyListViewNode
useOverviewMetrics
withEditReviewAccess
getPodMetricStats
getTopologyResourceObject
getResource
getTopologyEdgeItems
getTopologyGroupItems
getTopologyNodeItem
mergeGroup
getModifyApplicationAction
baseDataModelGetter
getWorkloadResources
contextMenuActions
CreateConnector
createConnectorCallback 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lokanandaprabhu lokanandaprabhu changed the title ODC-7726,ODC-7767: Expose remaining Topology components and utils to openshift-console/dynamic-plugin-sdk ODC-7726,ODC-7767: Expose Topology components and utils to openshift-console/dynamic-plugin-sdk Feb 7, 2025
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

@lokanandaprabhu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 465f12a link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhamilto
Copy link
Member

rhamilto commented Feb 7, 2025

/lgtm
/test okd-scos-e2e-aws-ovn

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lokanandaprabhu
Copy link
Contributor Author

/label acknowledge-critical-fixes-only
/label docs-approved

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. docs-approved Signifies that Docs has signed off on this PR labels Feb 7, 2025
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Feb 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 4cbde1f into openshift:master Feb 7, 2025
6 of 7 checks passed
@vojtechszocs
Copy link
Contributor

/cherrypick release-4.18

@openshift-cherrypick-robot

@vojtechszocs: #14705 failed to apply on top of branch "release-4.18":

Applying: Exposed topology components to dynamic plugins
Using index info to reconstruct a base tree...
M	dynamic-demo-plugin/console-extensions.json
M	dynamic-demo-plugin/locales/en/plugin__console-demo-plugin.json
M	frontend/packages/console-dynamic-plugin-sdk/README.md
M	frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts
M	frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts
M	frontend/packages/console-dynamic-plugin-sdk/src/shared-modules-init.ts
M	frontend/packages/console-dynamic-plugin-sdk/src/shared-modules.ts
M	frontend/packages/console-dynamic-plugin-sdk/tsconfig-base.json
M	frontend/packages/console-shared/src/constants/pod.ts
M	frontend/packages/topology/src/components/list-view/TopologyListViewNode.tsx
M	frontend/webpack.circular-deps.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/webpack.circular-deps.ts
Auto-merging frontend/packages/topology/src/components/list-view/TopologyListViewNode.tsx
Auto-merging frontend/packages/console-shared/src/constants/pod.ts
CONFLICT (content): Merge conflict in frontend/packages/console-shared/src/constants/pod.ts
Auto-merging frontend/packages/console-dynamic-plugin-sdk/tsconfig-base.json
Auto-merging frontend/packages/console-dynamic-plugin-sdk/src/shared-modules.ts
Auto-merging frontend/packages/console-dynamic-plugin-sdk/src/shared-modules-init.ts
Auto-merging frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts
Auto-merging frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts
Auto-merging frontend/packages/console-dynamic-plugin-sdk/README.md
CONFLICT (content): Merge conflict in frontend/packages/console-dynamic-plugin-sdk/README.md
Auto-merging dynamic-demo-plugin/locales/en/plugin__console-demo-plugin.json
Auto-merging dynamic-demo-plugin/console-extensions.json
CONFLICT (content): Merge conflict in dynamic-demo-plugin/console-extensions.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Exposed topology components to dynamic plugins

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/helm Related to helm-plugin component/knative Related to knative-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants