Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]CONSOLE-4404: Add the ability to specify second logo #14749

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[WIP]CONSOLE-4404: Add the ability to specify second logo #14749

wants to merge 6 commits into from

Conversation

Mylanos
Copy link
Contributor

@Mylanos Mylanos commented Feb 10, 2025 •
edited
Loading

TODO

  • what to do with custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend
  • handle different file formats

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

 ./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

@Mylanos
CONSOLE-4404: Extending the custom-logo API endpoint to facilitate tw…
b9d9872 
…o parameters - the type and theme of the logo, related CLI arguments parse tweaks
@Mylanos
CONSOLE-4404: Split the branding details retrieval function, add hook…
3f335ec 
… for fetching the logo from API based on the theme, add dark and light theme logo, related Theme Provider tweaks.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?

After:
https://github.com/user-attachments/assets/c52d0960-059d-4425-941e-01fa5db46cf4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 10, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2025
@openshift-ci openshift-ci bot requested review from jhadvig and TheRealJon February 10, 2025 17:21
@openshift-ci openshift-ci bot added component/backend Related to backend component/core Related to console core functionality labels Feb 10, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?

After:
https://github.com/user-attachments/assets/c52d0960-059d-4425-941e-01fa5db46cf4

bridge command used for testing:
./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?

After:
https://github.com/user-attachments/assets/c52d0960-059d-4425-941e-01fa5db46cf4

bridge command used for testing:
./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?

After:
https://github.com/user-attachments/assets/c52d0960-059d-4425-941e-01fa5db46cf4

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?

After:
https://github.com/user-attachments/assets/c52d0960-059d-4425-941e-01fa5db46cf4

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes

After:
https://github.com/user-attachments/assets/c52d0960-059d-4425-941e-01fa5db46cf4

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Mylanos
Mylanos commented Feb 11, 2025
View reviewed changes
cmd/bridge/main.go Outdated
@@ -110,6 +110,8 @@ func main() {

fBranding := fs.String("branding", "okd", "Console branding for the masthead logo and title. One of okd, openshift, ocp, online, dedicated, azure, or rosa. Defaults to okd.")
fCustomProductName := fs.String("custom-product-name", "", "Custom product name for console branding.")

fCustomLogoFiles := fs.String("custom-logo-files", "", "List of custom product images for console branding. Each entry consist of theme type as a key and path as a value.")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the info string

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 11, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 11, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Mylanos Mylanos changed the title [WIP]CONSOLE-4404: Add the ability to specify second logo [CONSOLE SIDE] [WIP]CONSOLE-4404: Add the ability to specify second logo Feb 11, 2025
Mylanos
Mylanos commented Feb 11, 2025
View reviewed changes
pkg/serverconfig/custom_logos.go Outdated
serverutils.SendResponse(w, http.StatusBadRequest, serverutils.ApiError{Err: errMsg})
return
}
// logo is a public content and revalidate the each new request before releasing cached files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// logo is a public content and revalidate the each new request before releasing cached files
// logo is a public content, revalidate each new request before releasing cached files

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend
  • handle different file formats

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend
  • handle different file formats

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend
  • handle different file formats

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Fetch favicon and ensure correct application to the DOM.
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend
  • handle different file formats

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend
  • handle different file formats

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 17, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • remove custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend
  • handle different file formats

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 17, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • what to do with custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend
  • handle different file formats

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mylanos
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Mylanos
CONSOLE-4404: set the global customLogo url even for customLogoFiles …
b13008b 
…argument, using the static images when to customLogos are configured
@Mylanos Mylanos force-pushed the CONSOLE-4404-add-ability-for-second-logo-in-PF6 branch from d88af9e to b13008b Compare February 17, 2025 16:23
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 17, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO

  • what to do with custom-logo CLI argument? (deprecated or redundant?)
  • Test logo functionality by creating console-custom-logo ConfigMaps.
  • Evaluate what should be done with the logos in img/ folder (Delete, move, or replace?)
  • Verify caching behavior for logos.
  • Document this configuration somewhere?
  • align with API and Operator changes
  • test backend
  • handle different file formats

After:

Screen.Recording.2025-02-10.at.18.06.06.mov

bridge command used for testing:

./bin/bridge --custom-logo-files='[{"type":"masthead","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-logo-light.svg"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-logo-dark.svg"}]},{"type":"favicon","logos":[{"theme":"light-theme","path":"frontend/public/imgs/okd-favicon.png"},{"theme":"dark-theme","path":"frontend/public/imgs/okd-favicon.png"}]}]'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@Mylanos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images b13008b link true /test images
ci/prow/okd-scos-images b13008b link true /test okd-scos-images
ci/prow/e2e-gcp-console b13008b link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Mylanos
Mylanos commented Feb 18, 2025
View reviewed changes
frontend/public/components/about-modal.tsx
@@ -162,16 +162,16 @@ AboutModalItems.displayName = 'AboutModalItems';
export const AboutModal: React.FC<AboutModalProps> = (props) => {
const { isOpen, closeAboutModal } = props;
const { t } = useTranslation();
const details = getBrandingDetails();
const { productName } = getBrandingDetails();
const customBranding = window.SERVER_FLAGS.customLogoURL || window.SERVER_FLAGS.customProductName;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO - investigate AboutModal when passing customLogoFiles to backend.

@Mylanos Mylanos mentioned this pull request Feb 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees
No one assigned
Labels
component/backend Related to backend component/core Related to console core functionality do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mylanos @openshift-ci-robot