-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-4201: Migrate ExtensionCatalog to use extensible Catalog system #14769
base: main
Are you sure you want to change the base?
Conversation
TheRealJon
commented
Feb 13, 2025
- Update to latest OLM v1 API changes
- Migrate some internal/private React components to the console-shared package so that they can be used in OLM v1 without coupling to internal console code.
- Fine tune console-shared and dynamic-plugin-sdk Catalog related components and extensions to add support for new behaviors:
- Array-like filter attributes get spread into individual filter values
- New comparator property on catalog item filters provides arbitrary sorting of filter attributes
- Add catalog items to OLM v1 extension definitions
- Create and update hooks that provide CatalogItem and CatalogCategory data to the ExtensionCatalog component
- Update ExtensionCatalog component to use console-shared CatalogServiceProvider and CatalogController to consume CatalogItems and CatalogCategories provided through new OLM v1 dynamic plugin extensions
- Update fbc injestion business logic to improve aggregation of catalog item attributes
…gin "console.catalog" extension points
…ting of filter values
@TheRealJon: This pull request references CONSOLE-4201 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
}; | ||
|
||
Timestamp.displayName = 'Timestamp'; | ||
export * from '@console/shared/src/components/datetime/Timestamp'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just remove this file and update imports that depend on this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, that required quite a few changes, so I decided not to do it just to keep the scope creep down. This PR ended up being a lot bigger than I expected anyway, but I tried :)
@TheRealJon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |