Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-4201: Migrate ExtensionCatalog to use extensible Catalog system #14769

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

TheRealJon
Copy link
Member

  • Update to latest OLM v1 API changes
  • Migrate some internal/private React components to the console-shared package so that they can be used in OLM v1 without coupling to internal console code.
  • Fine tune console-shared and dynamic-plugin-sdk Catalog related components and extensions to add support for new behaviors:
    • Array-like filter attributes get spread into individual filter values
    • New comparator property on catalog item filters provides arbitrary sorting of filter attributes
  • Add catalog items to OLM v1 extension definitions
  • Create and update hooks that provide CatalogItem and CatalogCategory data to the ExtensionCatalog component
  • Update ExtensionCatalog component to use console-shared CatalogServiceProvider and CatalogController to consume CatalogItems and CatalogCategories provided through new OLM v1 dynamic plugin extensions
  • Update fbc injestion business logic to improve aggregation of catalog item attributes

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2025

@TheRealJon: This pull request references CONSOLE-4201 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Update to latest OLM v1 API changes
  • Migrate some internal/private React components to the console-shared package so that they can be used in OLM v1 without coupling to internal console code.
  • Fine tune console-shared and dynamic-plugin-sdk Catalog related components and extensions to add support for new behaviors:
  • Array-like filter attributes get spread into individual filter values
  • New comparator property on catalog item filters provides arbitrary sorting of filter attributes
  • Add catalog items to OLM v1 extension definitions
  • Create and update hooks that provide CatalogItem and CatalogCategory data to the ExtensionCatalog component
  • Update ExtensionCatalog component to use console-shared CatalogServiceProvider and CatalogController to consume CatalogItems and CatalogCategories provided through new OLM v1 dynamic plugin extensions
  • Update fbc injestion business logic to improve aggregation of catalog item attributes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2025
@openshift-ci openshift-ci bot requested review from jhadvig and Mylanos February 13, 2025 21:12
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/backend Related to backend component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Feb 13, 2025
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Feb 13, 2025
};

Timestamp.displayName = 'Timestamp';
export * from '@console/shared/src/components/datetime/Timestamp';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just remove this file and update imports that depend on this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, that required quite a few changes, so I decided not to do it just to keep the scope creep down. This PR ended up being a lot bigger than I expected anyway, but I tried :)

Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@TheRealJon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn d7293cd link false /test okd-scos-e2e-aws-ovn
ci/prow/images d7293cd link true /test images
ci/prow/e2e-gcp-console d7293cd link true /test e2e-gcp-console
ci/prow/okd-scos-images d7293cd link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend component/core Related to console core functionality component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants