-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Update tectonic builder image to use golang-1.23 #14772
base: main
Are you sure you want to change the base?
Conversation
@jhadvig Do you know what we're still using tectonic-console-builder for? Is it only for Cypress tests? I thought we no longer used it for builds (even for CI), but I could be mistaken. |
@jhadvig: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
yes its the cypress. We have a story to remove the builder image, which I started to work on, but havent got chance to actually finish it cause it turned out to be a bit more tricky. That will resume the work so we can get rid of it asap. |
Thanks, @jhadvig. I built and pushed the image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
for the release PR
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @spadgett
Tied to openshift/release#61664