Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Update tectonic builder image to use golang-1.23 #14772

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Feb 14, 2025

@openshift-ci openshift-ci bot requested review from rhamilto and spadgett February 14, 2025 12:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@spadgett
Copy link
Member

@jhadvig Do you know what we're still using tectonic-console-builder for? Is it only for Cypress tests? I thought we no longer used it for builds (even for CI), but I could be mistaken.

Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@jhadvig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console fec4d92 link true /test e2e-gcp-console
ci/prow/backend fec4d92 link true /test backend
ci/prow/analyze fec4d92 link true /test analyze
ci/prow/images fec4d92 link true /test images
ci/prow/frontend fec4d92 link true /test frontend
ci/prow/okd-scos-images fec4d92 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhadvig
Copy link
Member Author

jhadvig commented Feb 18, 2025

@jhadvig Do you know what we're still using tectonic-console-builder for? Is it only for Cypress tests? I thought we no longer used it for builds (even for CI), but I could be mistaken.

yes its the cypress. We have a story to remove the builder image, which I started to work on, but havent got chance to actually finish it cause it turned out to be a bit more tricky. That will resume the work so we can get rid of it asap.

@spadgett
Copy link
Member

Thanks, @jhadvig. I built and pushed the image

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
for the release PR

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 18, 2025
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants