pullthrough is not optional #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
size/L
legionus
changed the title
legionus
force-pushed
the
alweays-pullthrough
branch
from
81543fa to
29dc0a4
Compare
|
/retest |
dmage
reviewed
Jun 14, 2018
| useBlobDescriptorCacheProvider bool, | ||
| ) (distribution.Namespace, error) { | ||
| cfg := &configuration.Configuration{ | ||
| Server: &configuration.Server{ | ||
| Addr: "localhost:5000", | ||
| }, | ||
| Pullthrough: &configuration.Pullthrough{ | ||
| Enabled: pullthrough, | ||
| Enabled: true, |
There was a problem hiding this comment.
Can we just drop this parameter from the configuration?
There was a problem hiding this comment.
@dmage I want to show warning if someone have it as false. But I can drop the Pullthrough initialization here.
|
Ben and I agree - we have no reason to keep supporting this. Approval
granted to terminate this code path.
…On Thu, Jun 14, 2018 at 5:13 AM, OpenShift CI Robot < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *APPROVED*
This pull-request has been approved by: *legionus
<#103#>*
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- OWNERS
<https://github.com/openshift/image-registry/blob/master/OWNERS>
[legionus]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pzdXoT0zaop9sRhFV-BV3P5wQw6uks5t8ilEgaJpZM4Unluz>
.
|
legionus
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
openshift-bot
added
the
needs-rebase
Signed-off-by: Gladkov Alexey <[email protected]>
legionus
force-pushed
the
alweays-pullthrough
branch
from
29dc0a4 to
8516796
Compare
openshift-bot
removed
the
needs-rebase
|
Rebased |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, legionus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openshift/origin#19969 (comment)
#101 (comment)
/cc @smarterclayton