nit

Signed-off-by: MohammedAbdi <[email protected]>
openshift · Feb 20, 2025 · a503cd4 · a503cd4
1 parent ea415f4
commit a503cd4
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/internal/controller/instaslice_controller.go b/internal/controller/instaslice_controller.go
@@ -730,7 +730,13 @@ func (r *InstasliceReconciler) removeInstasliceAllocation(ctx context.Context, a
 			return err
 		}
 	}
-	allocRequest := instaslice.Spec.PodAllocationRequests[podUid]
+	allocRequest, exists := instaslice.Spec.PodAllocationRequests[podUid]
+	// prevents using an empty allocRequest and logs an error when it's missing
+	if !exists {
+		log.Error(fmt.Errorf("podUid not found"), "Pod UID not found in Instaslice PodAllocationRequests", "podUid", podUid)
+		return fmt.Errorf("podUid %s not found in Instaslice PodAllocationRequests", podUid)
+	}
+
 	// update DeployedPodTotal Metrics by setting value to 0 as pod allocation is deleted
 	if err := r.UpdateDeployedPodTotalMetrics(string(allocation.Nodename), allocation.GPUUUID, allocRequest.PodRef.Namespace, allocRequest.PodRef.Name, allocRequest.Profile, 0); err != nil {
 		log.Error(err, "Failed to update deployed pod metrics", "nodeName", allocation.Nodename)