Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemonset fault tolerance #141

Merged
merged 28 commits into from
Oct 10, 2024
Merged

Conversation

asm582
Copy link
Contributor

@asm582 asm582 commented Oct 3, 2024

This PR covers the following scenarios:

  • The daemonset should continue to work after the pod restart(s), clean up dangling CIs and GIs, and delete CI and GIs when the user deletes a bunch of submitted pods.
  • The PR now consumes node selectors to point pods to nodes
  • The PR patches the node(s) with org.instaslice/

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2024
Copy link

openshift-ci bot commented Oct 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2024
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 3, 2024
Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2024
@asm582 asm582 marked this pull request as ready for review October 8, 2024 02:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
@openshift-ci openshift-ci bot requested review from mamy-CS and mrunalp October 8, 2024 02:03
@asm582 asm582 requested review from sairameshv and harche October 8, 2024 02:03
@asm582
Copy link
Contributor Author

asm582 commented Oct 8, 2024

All test cases pass locally and 80 pod submissions with sleep 5 command completes in about 260 seconds.

Copy link

openshift-ci bot commented Oct 9, 2024

@asm582: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harche
Copy link
Contributor

harche commented Oct 10, 2024

/cc @rphillips for the next round of review.

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8623421 into openshift:main Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants