Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git version info to binary #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add git version info to binary #332

wants to merge 1 commit into from

Conversation

rphillips
Copy link
Contributor

@rphillips rphillips commented Dec 12, 2024 •
edited
Loading

Add version info the controller and daemonset.

@openshift-ci openshift-ci bot requested review from sairameshv and tardieu December 12, 2024 19:27
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips
Once this PR has been reviewed and has the lgtm label, please assign harche for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2024
@rphillips rphillips force-pushed the add_version_info_to_binary branch 2 times, most recently from db0d1df to 5bc8917 Compare December 12, 2024 20:37
rphillips
rphillips commented Dec 12, 2024
View reviewed changes
Dockerfile.controller
ppc64el | ppc64le) ARCH='ppc64le' ;; \
aarch64) ARCH='arm64' ;; \
*) echo "unsupported architecture" ; exit 1 ;; \
x86_64 | amd64) ARCH='amd64' ;; \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a formatting change by the linter.

@rphillips rphillips force-pushed the add_version_info_to_binary branch from 5bc8917 to 955ecee Compare December 12, 2024 20:47
@rphillips rphillips force-pushed the add_version_info_to_binary branch from 955ecee to 73161e4 Compare December 12, 2024 20:53
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 12, 2024

@rphillips: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairameshv sairameshv Awaiting requested review from sairameshv

@tardieu tardieu Awaiting requested review from tardieu

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rphillips