Skip to content

Commit

Permalink
Merge pull request kubernetes#23261 from hongchaodeng/sched
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

kube-scheduler: cleanup duplicate GetAlgorithmProvider()

See [here](https://github.com/kubernetes/kubernetes/blob/ae88f08af09b8e721913544dcc2afdc31f98635e/plugin/pkg/scheduler/factory/factory.go#L177-L180).
The check is duplicate since CreateFromProvider will also do it.
  • Loading branch information
k8s-merge-robot committed Apr 11, 2016
2 parents f9ffeb8 + dc91b82 commit bf0e6e0
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions plugin/cmd/kube-scheduler/app/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,5 @@ func createConfig(s *options.SchedulerServer, configFactory *factory.ConfigFacto
}

// if the config file isn't provided, use the specified (or default) provider
// check of algorithm provider is registered and fail fast
_, err := factory.GetAlgorithmProvider(s.AlgorithmProvider)
if err != nil {
return nil, err
}

return configFactory.CreateFromProvider(s.AlgorithmProvider)
}

0 comments on commit bf0e6e0

Please sign in to comment.