Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-45359: Bump CSI sidecars to fix resizing tests #2196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-45359: Bump CSI sidecars to fix resizing tests #2196

wants to merge 1 commit into from

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Feb 3, 2025

We still can't rely on first condition being fs-expansion pending condition

Also, we don't really need this check here, because code above already checks for fs expansion

Fixes https://issues.redhat.com/browse/OCPBUGS-45359

@gnufied
UPSTREAM: 129618: Bump CSI sidecars to fix resizing tests
23449eb 
We still can't rely on first condition being fs-expansion pending condition

Also, we don't really need this check here, because code above already
checks for fs expansion
@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 3, 2025
@openshift-ci-robot
Copy link

@gnufied: This pull request references Jira Issue OCPBUGS-45359, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

We still can't rely on first condition being fs-expansion pending condition

Also, we don't really need this check here, because code above already checks for fs expansion

Fixes https://issues.redhat.com/browse/OCPBUGS-45359

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@gnufied
Copy link
Member Author

gnufied commented Feb 3, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 3, 2025
@openshift-ci-robot
Copy link

@gnufied: This pull request references Jira Issue OCPBUGS-45359, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bertinatto and tkashem February 3, 2025 20:45
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 4, 2025

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial 23449eb link true /test e2e-aws-ovn-serial
ci/prow/e2e-gcp 23449eb link true /test e2e-gcp
ci/prow/e2e-aws-ovn-crun 23449eb link true /test e2e-aws-ovn-crun
ci/prow/e2e-aws-ovn-cgroupsv2 23449eb link true /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-hypershift 23449eb link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-fips 23449eb link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-crun-wasm 23449eb link true /test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-runc 23449eb link true /test e2e-aws-ovn-runc
ci/prow/okd-scos-e2e-aws-ovn 23449eb link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bertinatto bertinatto mentioned this pull request Feb 12, 2025
Merged
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29450
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/42eccf10-e961-11ef-9181-ceaef9eb2aef-0

@bertinatto
Copy link
Member

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29450
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/65b1ca00-e984-11ef-80a9-a1e1c9219a6f-0

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29450
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7aa6a070-e984-11ef-914f-746d05a1f28d-0

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 13, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29450
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/99a46eb0-e9fe-11ef-94a4-1c00e193f6bc-0

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 13, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29450
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ba3b0300-ea44-11ef-8add-d72652152f55-0

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 17, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29450
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/80aa8db0-ed12-11ef-9020-c4c926d7088c-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@tkashem tkashem Awaiting requested review from tkashem

Assignees
No one assigned
Labels
backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnufied @openshift-ci-robot @bertinatto