OLS-1379: Add oc tools #2216
OLS-1379: Add oc tools #2216
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@onmete: This pull request references OLS-1379 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@asamal4 this should be easy to integrate once you have your PR ready. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
ols/src/tools/oc_cli.py
Outdated
| raise e | ||
|
|
||
|
|
||
| def oc_get(args: list[str]) -> subprocess.CompletedProcess: |
There was a problem hiding this comment.
input type: Why it is list[str] ? shouldn't it be just str ?
output type: I haven't tested, but I am thinking we can keep this as str (we can convert the output to str)
There was a problem hiding this comment.
Yup, output should be a string.
As for the input, technically it is a list of strings. From my experiments, llm had no issue returning it, but I'll try to double-check what is better understandable to the llm (list of strings/one string).
ols/src/tools/oc_cli.py
Outdated
| # List one or more resources by their type and names. | ||
| oc get rc/web service/frontend pods/web-pod-13je7 | ||
| """ | ||
| result = run_oc(["get", *sanitize_oc_args(args)]) |
There was a problem hiding this comment.
What will be the args value ? part of the command except oc get ?
There was a problem hiding this comment.
yes, besides sanitization, we can also catch the case when llm returns not just the args, but the full command oc get whatever instead of just whatever.
There was a problem hiding this comment.
Probably we are relying too much on model to generate the command here. Also this will require us to handle lot of corner cases (lot of rules to sanitize).
Anyways let's see if others have any opinion on this.
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign @asamal4 |
|
@onmete: This pull request references OLS-1379 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@onmete: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Adding oc tools.
OLS-1410
Type of change