Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lock and requirements #2240

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

onmete
Copy link
Contributor

@onmete onmete commented Feb 18, 2025

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci openshift-ci bot requested review from tisnik and xrajesh February 18, 2025 08:34
Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -31,7 +31,7 @@ COPY --from=lightspeed-rag-content /rag/embeddings_model ./embeddings_model
# (avoid accidental inclusion of local directories or env files or credentials)
COPY runner.py requirements.txt ./

RUN for a in 1 2 3 4 5; do pip3.11 install --no-cache-dir -r requirements.txt && break || sleep 15; done
RUN pip3.11 install --no-cache-dir -r requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @onmete , why is this being removed? We need this for CI since it fails rather often without it.
We potentially need to include the returning of the error in case of failure in the last attempt but remove it all together is going to make CI flaky again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed before, there is something weird going on with this.
The build in this PR passed with the loop, but it is failing without it (same behavior I get locally).
The build error is not something a repeat will fix, yet it somehow passes with the loop.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I failed to understand previously that the build was passing in the loop, I thought it was failing but not returning any error. And that it stopped failing due to us not hitting the exact failing condition. That's why I suggested the || exit 1 at the end.

Copy link

openshift-ci bot commented Feb 18, 2025

@onmete: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-e2e-ols-cluster 7de2087 link true /test 4.17-e2e-ols-cluster
ci/prow/4.15-images 7de2087 link true /test 4.15-images
ci/prow/images 7de2087 link true /test images
ci/prow/fips-image-scan-service 7de2087 link true /test fips-image-scan-service
ci/prow/4.17-images 7de2087 link true /test 4.17-images
ci/prow/4.16-images 7de2087 link true /test 4.16-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants