Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go version with security fixes #345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jgbernalp
Copy link
Contributor

No description provided.

@jgbernalp
Copy link
Contributor Author

/hold until appropriate task is created

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@openshift-ci openshift-ci bot requested review from kyoto and zhuje February 10, 2025 08:53
Copy link
Contributor

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@zhuje
Copy link
Contributor

zhuje commented Feb 10, 2025

/retest

1 similar comment
@zhuje
Copy link
Contributor

zhuje commented Feb 11, 2025

/retest

@zhuje
Copy link
Contributor

zhuje commented Feb 11, 2025

Maybe we need run go mod tidy to sync go.mod and go.sum?

@PeterYurkovich
Copy link
Contributor

Max go version is dependent on the base image used in the various Dockerfiles. The max go version on the quay.io/redhat-cne/openshift-origin-release:rhel-9-golang-1.22-openshift-4.17 as go-builder is 1.22.1. We will need to update the base images in addition to the changes in go.mod

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@jgbernalp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn c0463d9 link true /test e2e-aws-ovn
ci/prow/e2e-hypershift-conformance c0463d9 link true /test e2e-hypershift-conformance
ci/prow/images c0463d9 link true /test images
ci/prow/e2e-aws-ovn-upgrade c0463d9 link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Contributor Author

The base image needs to be updated first. Then we can include this change to be explicit regarding the go version for the base images when building the plugin. For now we need to wait until the base image is patched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants