Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quote to values in /etc/sysconfig/atomic-openshift-node #6041

Closed
wants to merge 1 commit into from
Closed

add quote to values in /etc/sysconfig/atomic-openshift-node #6041

wants to merge 1 commit into from

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Nov 7, 2017

In the containerized installation, values configured in
/etc/sysconfig/atomic-openshift-node are used as environmental
variables from EnvironmentFile= in
/etc/systemd/system/atomic-openshift-node.service. Therfore, if
configuration has multiple values with space like:

OPTIONS=--loglevel=3 --disable=proxy

importing the env variables fails. This patch add the double quote
("") to each variables.

You can reproduce the issue with following steps:

  1. Setting In /etc/sysconfig/atomic-openshift-node
OPTIONS=--loglevel=3 --disable=proxy
  1. import the env variables (and fail)
# source /etc/sysconfig/atomic-openshift-node
-bash: --disable=proxy: command not found

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2017

@nak3: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/logging a541a6f link /test logging

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3
Copy link
Contributor Author

nak3 commented Nov 7, 2017

Sorry, the cause of issue is not the quotation, but this openshift/origin#17212 I'm closing this PR.

@nak3 nak3 closed this Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants