Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlusterFS: Add configuration for auto creating block-hosting volumes #6150

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

jarrpa
Copy link
Contributor

@jarrpa jarrpa commented Nov 16, 2017

Naturally I didn't catch this until after the previous PR merged. :( Turns out I was using a wrong variable in my testing and was skipping over these bugs. This will unfortunately be needed for 3.7 as well.

Signed-off-by: Jose A. Rivera [email protected]

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2017
@sdodson
Copy link
Member

sdodson commented Nov 16, 2017

/kind bug
/priority p1
/lgtm

@sosiouxme
Copy link
Member

I tried this out and it seems to work (at least, the glusterblock-registry-provisioner-dc was deployed this time).

Looks like https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/6150/test_pull_request_openshift_ansible_extended_conformance_install/2386/ was a new test flake.

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@jarrpa: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/upgrade 7ea3097 link /test upgrade
ci/openshift-jenkins/install 7ea3097 link /test install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sosiouxme
Copy link
Member

this looks like this flake (albeit docker build instead of s2i)

this seems to be a flake common to openshift-ansible CI though I don't see a flake issue for it yet.

ETOOMANYFLAKES

@sosiouxme sosiouxme merged commit 9e97038 into openshift:master Nov 17, 2017
@sosiouxme
Copy link
Member

/cherrypick release-3.7

@openshift-cherrypick-robot

@sosiouxme: PR 6150 failed to apply on top of branch "release-3.7": exit status 128

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sosiouxme
Copy link
Member

ah, won't apply of course until #6119 merges. @sdodson want to just push this commit on top of that?

@sdodson
Copy link
Member

sdodson commented Nov 21, 2017

/cherrypick release-3.7

@openshift-cherrypick-robot

@sdodson: New pull request created: #6211

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson added a commit that referenced this pull request Nov 27, 2017
…6150-to-release-3.7

Automated cherry-pick of #6150 on release-3.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/P1 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants