Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NoVolumeNodeConflict from 3.9+ #7089

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Feb 9, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 9, 2018
@sdodson
Copy link
Member Author

sdodson commented Feb 9, 2018

/assign aveshagarwal

@aveshagarwal
Copy link
Contributor

@sdodson lgtm except as we discussed or IRC that CheckVolumeBinding is missing.

@sdodson
Copy link
Member Author

sdodson commented Feb 9, 2018

@michaelgugino should we get rid of roles/openshift_master_facts/lookup_plugins/openshift_master_facts_default_predicates.py at this point? Seems wholely duplicated from roles/lib_utils/lookup_plugins/openshift_master_facts_default_predicates.py ?

@michaelgugino
Copy link
Contributor

@sdodson that sounds fine to me. I might have missed that one when I was doing the refactoring.

I left the addon (logging, metrics) roles' plugins somewhat intact to try to keep those somewhat portable. If it's part of core openshift, it should most likely be in lib_utils.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2018
@sdodson
Copy link
Member Author

sdodson commented Feb 9, 2018

@aveshagarwal added CheckVolumeBinding
/retest

@aveshagarwal
Copy link
Contributor

@sdodson thanks. lgtm for predicates. Not sure I can provide lgtm here as I have not reviewed other changes.

@sdodson
Copy link
Member Author

sdodson commented Feb 16, 2018

/retest

@sdodson sdodson added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@michaelgugino
Copy link
Contributor

bot, retest this please

@sdodson
Copy link
Member Author

sdodson commented Feb 22, 2018

/test system-containers

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@sdodson: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/logging df793e9 link /test logging
ci/openshift-jenkins/install df793e9 link /test install
ci/openshift-jenkins/system-containers df793e9 link /test system-containers
ci/openshift-jenkins/extended_conformance_install_crio df793e9 link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants