-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NoVolumeNodeConflict from 3.9+ #7089
Conversation
/assign aveshagarwal |
@sdodson lgtm except as we discussed or IRC that |
@michaelgugino should we get rid of roles/openshift_master_facts/lookup_plugins/openshift_master_facts_default_predicates.py at this point? Seems wholely duplicated from roles/lib_utils/lookup_plugins/openshift_master_facts_default_predicates.py ? |
1cb0457
to
4c7918e
Compare
@sdodson that sounds fine to me. I might have missed that one when I was doing the refactoring. I left the addon (logging, metrics) roles' plugins somewhat intact to try to keep those somewhat portable. If it's part of core openshift, it should most likely be in lib_utils. |
4c7918e
to
df793e9
Compare
@aveshagarwal added CheckVolumeBinding |
@sdodson thanks. lgtm for predicates. Not sure I can provide lgtm here as I have not reviewed other changes. |
/retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
bot, retest this please |
/test system-containers |
/test all [submit-queue is verifying that this PR is safe to merge] |
@sdodson: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.