Disable console install when not 3.9 or newer #7108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
sdodson
requested changes
Feb 12, 2018
playbooks/init/basic_facts.yml
Outdated
| @@ -74,4 +74,4 @@ | |||
| tasks: | |||
| - set_fact: | |||
| openshift_web_console_install: False | |||
| when: openshift_deployment_subtype == 'registry' or ( osm_disabled_features is defined and 'WebConsole' in osm_disabled_features ) | |||
| when: not openshift.common.version_gte_3_9 or openshift_deployment_subtype == 'registry' or ( osm_disabled_features is defined and 'WebConsole' in osm_disabled_features ) | |||
There was a problem hiding this comment.
This fact is likely not available at this point in playbook execution, which is unfortunate as this is the best place to ensure all code paths skip console installation.
Try moving it https://github.com/openshift/openshift-ansible/blob/master/playbooks/common/private/components.yml#L23
spadgett
force-pushed
the
check-version-for-console-install
branch
from
3249102 to
7467ce4
Compare
|
Thanks @sdodson updated |
|
/lgtm |
spadgett
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
flake |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openshift/origin#18573
/assign @sdodson
@smarterclayton @stevekuznetsov