Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for OCP install #8003

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Fixes for OCP install #8003

merged 2 commits into from
Apr 18, 2018

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Apr 17, 2018 •
edited
Loading

Depends on openshift/origin#19262

This also ensures that the docker cert directory exists.

@sdodson sdodson requested a review from smarterclayton April 17, 2018 18:50
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2018
@sdodson sdodson requested a review from mtnbikenc April 17, 2018 18:51
@sdodson sdodson added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2018
@sdodson
Copy link
Member Author

sdodson commented Apr 17, 2018 •
edited
Loading

@mtnbikenc verified the image changes earlier today.

@sdodson
Copy link
Member Author

sdodson commented Apr 17, 2018

/retest

mtnbikenc
mtnbikenc approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2018
@mtnbikenc
Copy link
Member

Rebase?
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2018
@sdodson
Copy link
Member Author

sdodson commented Apr 17, 2018

No, I changed it to where origin would be once the referenced dependency merges. As soon as the dependency merges and those images are available in origin i'll move forward with this. Hopefully by end of day today.

@sdodson
Copy link
Member Author

sdodson commented Apr 18, 2018

/test all

@sdodson
Copy link
Member Author

sdodson commented Apr 18, 2018

bot, retest this please

@sdodson
Copy link
Member Author

sdodson commented Apr 18, 2018

/retest
bot, retest this please

@sdodson
Copy link
Member Author

sdodson commented Apr 18, 2018

bot, retest this please

1 similar comment
@sdodson
Copy link
Member Author

sdodson commented Apr 18, 2018

bot, retest this please

@sdodson
Copy link
Member Author

sdodson commented Apr 18, 2018

/test gcp-upgrade

@sdodson sdodson merged commit b38b8a1 into openshift:master Apr 18, 2018
@sdodson
Copy link
Member Author

sdodson commented Apr 18, 2018

Atomic is flaking on CSR approval, the moduel fails with a keyerror on timeout, #8032 to fix that

@openshift-ci-robot
Copy link

@sdodson: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp-upgrade 3d5a883 link /test gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Contributor

This broke gcp-upgrade, and after this merged everything else broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc mtnbikenc approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mtnbikenc mtnbikenc

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdodson @mtnbikenc @openshift-ci-robot @smarterclayton