Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to oc set env, since oc env is now removed #9497

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

soltysh
Copy link

@soltysh soltysh commented Aug 9, 2018

In openshift/origin#20139 I removed oc env and oc volume, this PR updates the ansible not to use them anymore.

/assign @sdodson

@vrutkovs vrutkovs closed this Aug 10, 2018
@vrutkovs vrutkovs reopened this Aug 10, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2018
@sdodson
Copy link
Member

sdodson commented Aug 10, 2018

/lgtm
Thanks!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2018
@vrutkovs
Copy link
Member

/retest

1 similar comment
@vrutkovs
Copy link
Member

/retest

@vrutkovs
Copy link
Member

/test gcp

@openshift-merge-robot openshift-merge-robot merged commit 1b2433b into openshift:master Aug 13, 2018
@soltysh soltysh deleted the remove_volume_env branch August 15, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants