emphasize deletion of all signatures if using invalid identity #10122
Conversation
openshift-ci-robot
added
the
size/S
admin_guide/image_signatures.adoc
Outdated
| Using the `--save` flag on already verified image together with invalid GPG key | ||
| or invalid expected identity causes the saved verification status to be removed, | ||
| and the image will become unverified. | ||
| or invalid expected identity causes the saved verification status with all |
admin_guide/image_signatures.adoc
Outdated
| or invalid expected identity causes the saved verification status to be removed, | ||
| and the image will become unverified. | ||
| or invalid expected identity causes the saved verification status with all | ||
| previous signatures to be removed, and the image will become unverified. |
There was a problem hiding this comment.
couldn't come up with any better adjective so I just removed the 'previous'
There was a problem hiding this comment.
sorry if it wasn't clear, that's exactly what i was suggesting you do :)
wozniakjan
force-pushed
the
image_signature/emphasize_sig_deletion
branch
from
b37ceab to
6f2d730
Compare
|
lgtm |
|
Thanks, @wozniakjan! LGTM. The bug attached to this is set for OCP 3.6, so is this applicable for 3.6+? No QE required. |
|
yes, 3.6+ |
|
Thanks! |
|
/cherrypick enterprise-3.7 |
|
@bmcelvee: new pull request created: #10403 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-3.9 |
|
@bmcelvee: new pull request created: #10404 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-3.10 |
|
@bmcelvee: new pull request created: #10405 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is to supplement openshift/origin#19976, @bmcelvee in case you already created the PR we talked about, feel free to close this one. I was trying to find yours but couldn't and I had some spare time on Friday for this anyway :)
ptal @bmcelvee, @bparees