Older oc versions didnt support API negotiation #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,6 +64,13 @@ No events. | |||
| ---- | |||
| ==== | |||
|
|
|||
| [WARNING] | |||
| ==== | |||
| Older versions of `oc` didn't have the ability to negotiate API versions against a server. So if you are using `oc` prior | |||
There was a problem hiding this comment.
Versions of oc prior to 1.0.5 did not have the ability to negotiate API versions...
fabianofranz
force-pushed
the
new_app_search
branch
2 times, most recently
from
869fb33 to
69fd09c
Compare
|
Anything else here? |
| @@ -64,6 +64,13 @@ No events. | |||
| ---- | |||
| ==== | |||
|
|
|||
| [WARNING] | |||
| ==== | |||
| Versions of oc prior to 1.0.5 did not have the ability to negotiate API versions against a server. So if you are using `oc` up | |||
There was a problem hiding this comment.
The first oc can be marked up with backticks.
|
@fabianofranz This will need to be conditionalized for Origin vs OSE since the version numbers are different. |
|
@adellape good catch, do we have any example of something like that in openshift-docs? |
|
@fabianofranz Yeah, sorry, I should have linked! Lot of use in this one, for example: https://raw.githubusercontent.com/openshift/openshift-docs/master/install_config/upgrades.adoc |
fabianofranz
force-pushed
the
new_app_search
branch
from
69fd09c to
d186bfa
Compare
|
@adellape Should be fixed, PTAL. |
|
👍 |
adellape
added a commit
that referenced
this pull request
Nov 4, 2015
Older oc versions didnt support API negotiation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liggitt This fixes openshift/origin#5254. I checked that recent versions do api negotiation correctly. So any other topics we could add this warning, or is it good enough?