-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvementes to the SCC documentation #4554
Conversation
Looks ok to me technically. |
PTAL @openshift/team-documentation |
@openshift/team-documentation ping |
@php-coder Thanks! Overall, this looks good to me. I will just make some very minor style edits in a separate follow-up PR. First:
|
Also update description of restricted SCC.
3cbda59
to
bee4bce
Compare
<1> The `*FSGroup*` strategy which dictates the allowable values for the | ||
<1> A list of capabilities that can be requested by a pod. An empty list means | ||
that none of capabilities can be requested while the special symbol `***` | ||
allows any capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahardin-rh The only change that is specific to 3.6 is the usage of *
in allowedCapabilities
: openshift/origin#12875 (comment)
@ahardin-rh Squashed.
I'm curious why documentation team is using the follow-up PRs instead of requesting comments to the original PR? Anyway, could I ask you to always add me to CC to the follow-up PRs of my PRs? I'd like to to learn from my mistakes and also to take best documentation practices from your team. |
@php-coder Thanks! We tend to do quick follow-up PRs for simple style edits just to save you time. I will be sure to tag you in the follow-up PR. 🍻 |
No revision history needed |
Based on the question about capabilities and SCC, I did an attempt to improve our documentation and make some points clearer.
PTAL @pweil- @smarterclayton
CC @mfojtik
JFYI @brenton