Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvementes to the SCC documentation #4554

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

php-coder
Copy link

Based on the question about capabilities and SCC, I did an attempt to improve our documentation and make some points clearer.

PTAL @pweil- @smarterclayton
CC @mfojtik
JFYI @brenton

@smarterclayton
Copy link
Contributor

Looks ok to me technically.

@php-coder
Copy link
Author

PTAL @openshift/team-documentation

@php-coder
Copy link
Author

@openshift/team-documentation ping

@ahardin-rh
Copy link
Contributor

@php-coder Thanks! Overall, this looks good to me. I will just make some very minor style edits in a separate follow-up PR. First:

  1. Can you please squash this into one commit?
  2. Is this targeting 3.6?

Also update description of restricted SCC.
@php-coder php-coder force-pushed the scc_and_capabilities branch from 3cbda59 to bee4bce Compare June 14, 2017 17:01
<1> The `*FSGroup*` strategy which dictates the allowable values for the
<1> A list of capabilities that can be requested by a pod. An empty list means
that none of capabilities can be requested while the special symbol `***`
allows any capabilities
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahardin-rh The only change that is specific to 3.6 is the usage of * in allowedCapabilities: openshift/origin#12875 (comment)

@php-coder
Copy link
Author

php-coder commented Jun 14, 2017

@ahardin-rh Squashed.

I will just make some very minor style edits in a separate follow-up PR.

I'm curious why documentation team is using the follow-up PRs instead of requesting comments to the original PR?

Anyway, could I ask you to always add me to CC to the follow-up PRs of my PRs? I'd like to to learn from my mistakes and also to take best documentation practices from your team.

@ahardin-rh
Copy link
Contributor

@php-coder Thanks! We tend to do quick follow-up PRs for simple style edits just to save you time.

I will be sure to tag you in the follow-up PR. 🍻

@ahardin-rh ahardin-rh merged commit 0a1c749 into openshift:master Jun 14, 2017
@ahardin-rh ahardin-rh self-assigned this Jun 14, 2017
@php-coder php-coder deleted the scc_and_capabilities branch June 14, 2017 20:11
@ahardin-rh
Copy link
Contributor

No revision history needed

@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging Jul 7, 2017
@vikram-redhat vikram-redhat removed this from the Future Release milestone Aug 9, 2017
@vikram-redhat vikram-redhat modified the milestones: Staging, Future Release, OCP 3.6 GA Aug 9, 2017
@vikram-redhat vikram-redhat modified the milestones: OCP 3.6 GA, Staging, TEMP Sep 7, 2017
@vikram-redhat vikram-redhat modified the milestones: OCP 3.6 GA, Staging, TEMP Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants