Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an annotation to provide a route cookie #5309

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

pecameron
Copy link

Route annotation:
router.openshift.io/router.cookie.name
can be used to set a cookie name for the route.

The cookie must pass regex filter "^[a-zA-Z0-9_-][a-zA-Z0-9_-]*"

https://trello.com/c/dZpU26W9
(3) Allow routes to set the cookie names for session stickiness

origin PR 16454
openshift/origin#16454

@pecameron
Copy link
Author

@knobunc @bfallonf PTAL

@pecameron pecameron force-pushed the cookie-name branch 2 times, most recently from ae34791 to e1ac980 Compare September 20, 2017 19:16
Route annotation:
router.openshift.io/router.cookie.name
can be used to set a cookie name for the route.

Added ROUTER_COOKIE_NAME for setting cookie name for all routes.

The cookie must pass regex filter "[a-zA-Z0-9_-]+"

https://trello.com/c/dZpU26W9
(3) Allow routes to set the cookie names for session stickiness

origin PR 16454
openshift/origin#16454
@bfallonf
Copy link

@pecameron Thanks! If this is a new feature, would it require a more thorough write-up on how and why to use it? Or does this work with something that's already existing? I can see the corresponding card on the docs board, so I can add this to that for now.

@pecameron
Copy link
Author

pecameron commented Sep 21, 2017 via email

@bfallonf
Copy link

Thanks @pecameron . I'll merge this, then add the explanation to the docs card for the next sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants