add documentation for template.openshift.io/bindable #6206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparees
requested changes
Nov 7, 2017
dev_guide/templates.adoc
Outdated
|
|
||
| === Marking Templates as Bindable | ||
|
|
||
| The template service broker advertises one service in its catalogue for each |
There was a problem hiding this comment.
s/catalogue/catalog/ (sorry)
|
one nit and lgtm. |
jim-minter
force-pushed
the
issue16726
branch
from
dfe9c95 to
4a84686
Compare
|
nit fixed, thanks |
|
Thanks, @jim-minter! Looks like has merged, so I'll move forward with this PR. Label for enterprise-3.7, dedicated (3.7), and online (3.7)? |
|
@bmcelvee sgtm! |
|
[rev_history] |
bmcelvee
pushed a commit
to bmcelvee/openshift-docs
that referenced
this pull request
Nov 9, 2017
(cherry picked from commit 4a84686) xref:"openshift#6206"
bmcelvee
pushed a commit
to bmcelvee/openshift-docs
that referenced
this pull request
Nov 9, 2017
(cherry picked from commit 4a84686) xref:"openshift#6206"
bmcelvee
pushed a commit
to bmcelvee/openshift-docs
that referenced
this pull request
Nov 9, 2017
(cherry picked from commit 4a84686) xref:"openshift#6206"
This was referenced Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.7. After openshift/origin#17215 has merged.
@bmcelvee @bparees