Documenting Cluster Loader's additional functionality. #7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documenting synchronization primitives and the possibility to create ConfigMaps and Secrets from files as implemented by openshift/origin#17894
openshift-ci-robot
added
the
size/M
|
@ahardin-rh PTAL |
|
@jmencak Thanks! Is this for 3.9+, or for 3.7+? |
ahardin-rh
reviewed
Jan 24, 2018
| defines HTTP server port to listen on (9090 by default). | ||
|
|
||
| |`running` | ||
| |A boolean. Wait for pods with labels matching `selectors` to go into Running state? |
There was a problem hiding this comment.
Is there a reason why these are punctuated by ?
There was a problem hiding this comment.
Like selectors? Yes, because I'm trying to refer to the selectors below. Could be phrased better I guess.
There was a problem hiding this comment.
@jmencak Okay, thanks. I'm going to make some minor proposed edits in a follow-up PR and tag you in that for review.
|
This is for 3.9. |
|
[rev_history] |
ahardin-rh
pushed a commit
to ahardin-rh/openshift-docs
that referenced
this pull request
Jan 24, 2018
Documenting synchronization primitives and the possibility to create ConfigMaps and Secrets from files as implemented by openshift/origin#17894 (cherry picked from commit c85b8a9) xref:openshift#7297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting synchronization primitives and the possibility to create ConfigMaps and Secrets from files as implemented by openshift/origin#17894