Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo changes to daemonset RBAC docs #8126

Merged

Conversation

enj
Copy link

@enj enj commented Mar 14, 2018

Revert "Remove daemonset from RBAC docs"

This reverts commit 9912d86.

Revert "Removed link to Granting Users Daemonset Permissions as followup to PR#7981"

This reverts commit 015ed38.

Bug 1536304
Bug 1501514

xref: openshift/origin#18971

/assign @simo5 @ahardin-rh

Need to undo these changes until we can safely enable daemonset permissions.

Revert "Remove daemonset from RBAC docs"

This reverts commit 9912d86.

Revert "Removed link to Granting Users Daemonset Permissions as followup to PR#7981"

This reverts commit 015ed38.

Bug 1536304
Bug 1501514
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2018
@enj
Copy link
Author

enj commented Mar 14, 2018

/cherrypick enterprise-3.9

@openshift-cherrypick-robot

@enj: once the present PR merges, I will cherry-pick it on top of enterprise-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simo5
Copy link

simo5 commented Mar 14, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2018
@vikram-redhat
Copy link
Contributor

@enj - Hey Mo, please don't use the cherrypick command. Only associates from the documentation team can use that. When you want to get the docs team attention, either tag the team with openshift/team-documentation or the right docs associate.

@ahardin-rh - PTAL.

@ahardin-rh
Copy link
Contributor

LGTM. Thanks!

@ahardin-rh ahardin-rh merged commit f3a17af into openshift:master Mar 16, 2018
@openshift-cherrypick-robot

@enj: new pull request created: #8160

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enj
Copy link
Author

enj commented May 4, 2018

@ahardin-rh @kalexand-rh I need this un-reverted (i.e. my original change is correct now).

@kalexand-rh
Copy link
Contributor

Mo says that this permission is granted by default in v3.9.26-1 and later. See #9055.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.9 lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants