-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo changes to daemonset RBAC docs #8126
Undo changes to daemonset RBAC docs #8126
Conversation
/cherrypick enterprise-3.9 |
@enj: once the present PR merges, I will cherry-pick it on top of enterprise-3.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@enj - Hey Mo, please don't use the cherrypick command. Only associates from the documentation team can use that. When you want to get the docs team attention, either tag the team with openshift/team-documentation or the right docs associate. @ahardin-rh - PTAL. |
LGTM. Thanks! |
@enj: new pull request created: #8160 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahardin-rh @kalexand-rh I need this un-reverted (i.e. my original change is correct now). |
Mo says that this permission is granted by default in v3.9.26-1 and later. See #9055. |
Revert "Remove daemonset from RBAC docs"
This reverts commit 9912d86.
Revert "Removed link to Granting Users Daemonset Permissions as followup to PR#7981"
This reverts commit 015ed38.
Bug 1536304
Bug 1501514
xref: openshift/origin#18971
/assign @simo5 @ahardin-rh
Need to undo these changes until we can safely enable daemonset permissions.