Docs explaining the new ingress-to-route controller #8596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
@knobunc PTAL |
|
This is for openshift/origin#18658 |
knobunc
requested changes
Apr 4, 2018
architecture/networking/routes.adoc
Outdated
| == Support for Kubernetes Ingress objects in Openshift | ||
|
|
||
| In an effort to support the Kubernetes method of managing external access to services | ||
| in a cluster an ingress to route controller has been created. This controller watches |
There was a problem hiding this comment.
Can we use Ingress and Route consistently (or ingress and route)
Miciah
reviewed
Apr 5, 2018
architecture/networking/routes.adoc
Outdated
| @@ -833,3 +833,53 @@ $ oc expose service/<name> --hostname="m.api.openshift.org" | |||
| $ oc expose service/<name> --hostname="kates.net" | |||
| $ oc expose service/<name> --hostname="api.kates.net" | |||
| ---- | |||
|
|
|||
|
|
|||
| == Support for Kubernetes Ingress objects in Openshift | |||
| kind: Route | ||
| apiVersion: route.openshift.io/v1 | ||
| metadata: | ||
| name: test-a34th |
There was a problem hiding this comment.
Maybe a callout to say that the name is automatically generated, with the ingress's name as a prefix.
JacobTanenbaum
force-pushed
the
IngressDocs
branch
from
cec4689 to
d7b6117
Compare
zhaozhanqi
reviewed
Apr 8, 2018
| spec: | ||
| rules: | ||
| - host: test.com | ||
| http: |
|
Verified with @JacobTanenbaum that this was technically ok. I made a new PR for this: @zhaozhanqi this included validating the YAML. Please let me know if there's anything more needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs associated with Claytons addition of a route-to-ingress controller
PR18658