Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove openshift_set_node_ip/openshift_ip docs #9702

Merged
merged 1 commit into from
May 31, 2018

Conversation

sjenning
Copy link

xref https://bugzilla.redhat.com/show_bug.cgi?id=1584486

In 3.10, the use of openshift_set_node_ip and openshift_ip are no longer supported

@smarterclayton @derekwaynecarr @sdodson

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 31, 2018
@ahardin-rh ahardin-rh added this to the Future Release milestone May 31, 2018
@ahardin-rh
Copy link
Contributor

LGTM

@sdodson
Copy link
Member

sdodson commented May 31, 2018

/lgtm
I fear we'll hear about this being a problem for customers that they can no longer configure which interface to use. We should think about ensuring that we have some method to handle that in the future.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2018
@sjenning
Copy link
Author

Unfamiliar with docs merge policy. Who merges this?

@ahardin-rh
Copy link
Contributor

@sjenning I can 🖐️

@vikram-redhat FYI, I don't think this needs QE review. I added it to the 3.10 release notes tracker so that we can call this change out there.

@ahardin-rh ahardin-rh merged commit b38ec9a into openshift:master May 31, 2018
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.10

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #9707

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.10 lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants