Bug 1572859: Rm openshift_hostname #9744
Conversation
openshift-ci-robot
added
the
size/M
| * The master host uses port *10250* to reach the nodes and does not go over SDN. It depends on the target host of the deployment and uses the computed values of `*openshift_hostname*` and `*openshift_public_hostname*`. | ||
| * The master host uses port *10250* to reach the nodes and does not go over SDN. | ||
| It depends on the target host of the deployment and uses the computed values of | ||
| `*openshift_public_hostname*`. |
There was a problem hiding this comment.
Does this still behave the same way wrt openshift_public_hostname?
There was a problem hiding this comment.
I think that neither of those variables are relevant to this particular line. The only thing that matters now is the host's hostname which is what it will use to register to the API.
@sjenning is this correct
There was a problem hiding this comment.
I believe that openshift_public_hostname is only used when generating certs (allowing a different external name to be included in the cert), not configuring the node.
There was a problem hiding this comment.
It's going to reach the kubelet via the hostname that the node registers with afaik. I'd just get rid of this last bullet point.
|
Does this section need to be updated? |
openshift-bot
added
the
needs-rebase
openshift-bot
removed
the
needs-rebase
openshift-bot
added
the
needs-rebase
|
@adellape - this needs to be fixed for 3.10. |
openshift-bot
removed
the
needs-rebase
|
Removed |
|
@adellape - make sure to CP this to the enterprise-3.11 branch now as well. I have changed the milestones and labels. |
|
@adellape - is this done? |
|
@adellape - closing this in favor of the one @kalexand-rh is now working on and that covers the same areas: #11430 |
xref: https://bugzilla.redhat.com/show_bug.cgi?id=1572859
@sjenning @sdodson PTAL.
Will also get a release note in via #8651.