BZ1586368 Remove references to setting openshift_dns_ip #9875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node config value dnsIP is no longer configurable.
openshift-ci-robot
added
the
size/M
|
@sjenning, will you PTAL? |
|
LGTM thanks |
|
@jianlinliu, since you approved https://bugzilla.redhat.com/show_bug.cgi?id=1586368, do you agree with this doc change? @openshift/team-documentation, PTAL |
kalexand-rh
reviewed
Jun 19, 2018
| . If the `*dnsIP*` parameter is omitted from the *_node-config.yaml_* | ||
| file, then the value defaults to the kubernetes service IP, which is the first | ||
| nameserver in the pod's *_/etc/resolv.conf_* file. | ||
| . {product-title} then sets the pod's first namesever to the IP address of |
There was a problem hiding this comment.
s/namesever/nameserver
kalexand-rh
added
the
peer-review-needed
|
LGTM |
|
@sdodson: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-bot
added
the
needs-rebase
|
@sdodson, will you please rebase? @openshift/team-documentation, PTAL |
|
LGTM (after typo fix) 🐛 |
kalexand-rh
added
peer-review-done
|
Rebased and edited via #10537. Closing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node config value dnsIP is no longer configurable in 3.10.
/cc @sjenning